Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify extract-features return payload #104

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

naaish-adam
Copy link
Collaborator

@naaish-adam naaish-adam commented Jul 15, 2024

Description

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

@naaish-adam naaish-adam self-assigned this Jul 15, 2024
Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: 4a6fc7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lottiefiles/relottie-extract-features Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@naaish-adam naaish-adam requested a review from Aidosmf July 15, 2024 07:21
@lottiefiles-bot
Copy link
Collaborator

lottiefiles-bot commented Jul 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/last/dist/index.js 0 B (+100% 🔺) 0 ms (+100% 🔺) 12 ms (+55.72% 🔺) 12 ms
packages/last-builder/dist/index.js 0 B (+100% 🔺) 0 ms (+100% 🔺) 8 ms (+6.25% 🔺) 8 ms
packages/relottie/dist/index.js 21.46 KB (0%) 430 ms (0%) 1.2 s (+82.16% 🔺) 1.6 s
packages/relottie-parse/dist/index.js 10.67 KB (0%) 214 ms (0%) 352 ms (+47.44% 🔺) 565 ms
packages/relottie-stringify/dist/index.js 0 B (+100% 🔺) 0 ms (+100% 🔺) 12 ms (+44.29% 🔺) 12 ms
packages/relottie-extract-features/dist/index.js 5.36 KB (0%) 108 ms (0%) 47 ms (-29.74% 🔽) 154 ms
packages/relottie-metadata/dist/index.js 5.07 KB (0%) 102 ms (0%) 48 ms (+5.34% 🔺) 150 ms

Copy link
Collaborator

@Aidosmf Aidosmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@naaish-adam naaish-adam merged commit 3d1087f into main Jul 15, 2024
3 checks passed
@naaish-adam naaish-adam deleted the naaish/update-extract-features-return-type branch July 15, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants