refactor: return when static value is found in animatedValueStaticChe…

…cker (#108) * refactor(extract-features): improve animatedValueStaticChecker * docs: add changeset * refactor: fix format
LottieFiles · Aug 28, 2024 · d470856 · d470856
1 parent bfbe50b
commit d470856
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/great-panthers-swim.md b/.changeset/great-panthers-swim.md
@@ -0,0 +1,5 @@
+---
+'@lottiefiles/relottie-extract-features': patch
+---
+
+refactor: break a loop when static-value is found in animatedValueStaticChecker
diff --git a/packages/relottie-extract-features/src/used-features.ts b/packages/relottie-extract-features/src/used-features.ts
@@ -126,13 +126,15 @@ export const animatedValueStaticChecker: IsFeatureUsedChecker<Element> = (node):
 
   if (valueNode.title !== OT.animatedValueStatic) return objectNodeChecker(valueNode);
 
-  const staticValueNode = valueNode.children.find((child) => child.title === NT.staticValue);
+  for (const childNode of valueNode.children) {
+    if (childNode.title !== NT.staticValue) continue;
 
-  const targetNode = staticValueNode?.children[0];
+    const staticValueNode = childNode.children[0];
 
-  if (targetNode?.type !== 'primitive') return false;
+    if (staticValueNode?.value === 0) return false;
 
-  if (targetNode.value === 0) return false;
+    return true;
+  }
 
   return true;
 };