fix: dilate static-value checker (#102)

LottieFiles · Jul 12, 2024 · 8c19bf1 · 8c19bf1
1 parent c53e35c
commit 8c19bf1
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 9 deletions.
diff --git a/.changeset/sixty-moose-kick.md b/.changeset/sixty-moose-kick.md
@@ -0,0 +1,5 @@
+---
+'@lottiefiles/relottie-extract-features': patch
+---
+
+fix: dilate is disabled and not used if its static-value is 0
diff --git a/packages/relottie-extract-features/__tests__/__snapshots__/features/karting.snap b/packages/relottie-extract-features/__tests__/__snapshots__/features/karting.snap
@@ -892,14 +892,14 @@ exports[`relottie-extract-features fixtures features Test in karting.json should
       "y": 1,
     },
     "dilate" => {
-      "n": 0,
+      "n": 1,
       "parents": Map {
         "mask" => {
-          "n": 0,
-          "y": 1,
+          "n": 1,
+          "y": 0,
         },
       },
-      "y": 1,
+      "y": 0,
     },
     "shape-list" => {
       "n": 0,

diff --git a/packages/relottie-extract-features/__tests__/__snapshots__/features/slots-img.snap b/packages/relottie-extract-features/__tests__/__snapshots__/features/slots-img.snap
@@ -1052,14 +1052,14 @@ exports[`relottie-extract-features fixtures features Test in slots-img.json shou
       "y": 6,
     },
     "dilate" => {
-      "n": 0,
+      "n": 6,
       "parents": Map {
         "mask" => {
-          "n": 0,
-          "y": 6,
+          "n": 6,
+          "y": 0,
         },
       },
-      "y": 6,
+      "y": 0,
     },
     "start-time" => {
       "n": 0,

diff --git a/packages/relottie-extract-features/src/used-features.ts b/packages/relottie-extract-features/src/used-features.ts
@@ -14,7 +14,7 @@ import type {
   Root,
 } from '@lottiefiles/last';
 
-const { intBoolean: IBT, number: NT } = TITLES;
+const { element: ET, intBoolean: IBT, number: NT, object: OT } = TITLES;
 
 export type NodeWithTitle = Root | ArrayNode | ObjectNode | Attribute | Element | Collection;
 
@@ -116,6 +116,27 @@ export const timeStretchChecker: IsFeatureUsedChecker<Attribute> = (node): boole
   }
 };
 
+/**
+ * If dilate's (aka Mask Expansion) non-animated static-value is set to 0 then it's disabled and not used.
+ */
+export const dilateChecker: IsFeatureUsedChecker<Element> = (node): boolean => {
+  const valueNode = node.children[0];
+
+  if (!valueNode) return false;
+
+  if (valueNode.title !== OT.animatedValueStatic) return objectNodeChecker(valueNode);
+
+  const staticValueNode = valueNode.children.find((child) => child.title === NT.staticValue);
+
+  const targetNode = staticValueNode?.children[0];
+
+  if (targetNode?.type !== 'primitive') return false;
+
+  if (targetNode.value === 0) return false;
+
+  return true;
+};
+
 export const FEATURE_CHECKERS = new Map<
   AnyTitle,
   | IsFeatureUsedChecker<Attribute>
@@ -136,6 +157,7 @@ export const FEATURE_CHECKERS = new Map<
   [IBT.randomize, intBooleanNodeChecker],
   [IBT.matteTarget, intBooleanNodeChecker],
   [NT.timeStretch, timeStretchChecker],
+  [ET.dilate, dilateChecker],
 ]);
 
 export const isFeatureUsed = (feature: AnyTitle, node: NodeWithTitle): boolean => {