Closed
Conversation
…x/add_data_checks
…add_data_checks
…add_data_checks
fix: use pathlib.Path for save_path
… fix/add_data_checks
Fix/add data checks
lachlangrose
reviewed
Jun 3, 2025
Member
lachlangrose
left a comment
lachlangrose
left a comment
There was a problem hiding this comment.
@noellehmcheng I'm not sure whether we still use map2model... @rabii-chaarani do you know? I remember writing a geopandas alternative. Looking at the code there are a few paths where run gets called but do we really need it?
Also this action is not really appropriate, it is only running on a single operating system and for a single python version. It should be run on all operating systems and for all current python versions which can be read from the organisation environment variables. See https://github.com/Loop3D/LoopStructural/blob/master/.github/workflows/tester.yml
Member
|
@lachlangrose I don't think we need map2model anymore, we use the geopandas code you wrote before. |
Contributor
Author
|
refer to #204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly specified Python version to solve the incompatibility issue - map2model requires Python 3.10. Used Github provided actions to set up python and conda environments