feat: persist sidebar toggle state #569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doprz
added
ready-for-review
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
Screen.Recording.2025-03-23.at.3.58.17.AM.mp4
after:
Screen.Recording.2025-03-23.at.3.57.18.AM.mp4
We need a loading state so that the sidebar doesn't pop in/pop out when loading (we need to know if we want it open or closed before we display it for the first time, otherwise we see the transition of it changing open-->closed or vice-versa depending on the default)
See ugly versions without loading states
Screen.Recording.2025-03-23.at.4.06.39.AM.mov
Screen.Recording.2025-03-23.at.4.08.14.AM.mov
Yes, react query is overkill for this, but it's about time we have it in the repo. We need a good loading state manager, and react query is good for that (usually across network, but chrome storage is async too)
This change is