Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Clean & Reorganise of 1.19 #25

Merged
merged 12 commits into from
May 20, 2023
Merged

Conversation

sisby-folk
Copy link
Contributor

Fixes #23, #21, #20

Basically:

  • smashed the fabriclike/quilt/fabric packages into one fabric package
  • used full midnightlib for both platforms instead of the midnightconfig class file for just fabric
  • bumped gradle and loom
  • bumped deps to match 1.19.2
  • Reorganised all the platform-specific code to be more architectury-y (using more specialized impl classes)
  • Cleaned and shortened a lot of boilerplate in general.
  • Fixed enchantments appearing in tables, villagers, treasure, and mods on chestplates using a simple mixin.

In the end, the project should be a lot more brief. Happy to backport the project structure to the 1.18 branch if needed after.

@SammySemicolon
Copy link
Contributor

My savior

@SammySemicolon SammySemicolon merged commit 2ffdc30 into LodestarMC:1.19 May 20, 2023
@egshels
Copy link
Member

egshels commented May 20, 2023

you are so frekaing awesome for that tysm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants