Repository navigation
Read a locale's script and region only from its language tag - #983
Merged
Merged
Conversation
`Lang::parse_locale` scanned every subtag of a locale for a script, a region or `BR`, including those after an extension or private-use singleton. Their subtags can look like scripts or regions without being one, so `zh-Hant-TW-x-hans` parsed as Simplified Chinese and `pt-PT-x-br` as Brazilian Portuguese. The scan now stops at the first single-letter subtag, which starts an extension or private use. The test covers both cases and extensions that follow a script or region of the tag itself.
CryZe
enabled auto-merge (squash)
November 15, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lang::parse_localescans every subtag of a locale for a script, a region orBR, including those after an extension or private-use singleton (-u-…,-x-…). Their subtags can look like scripts or regions without being one, so since #982zh-Hant-TW-x-hansparses as Simplified Chinese, andpt-PT-x-brhas always parsed as Brazilian Portuguese.The scan now stops at the first single-letter subtag, which starts an extension or private use. The existing locale test gains these cases and extensions that follow a script or region of the tag itself (
zh-Hans-u-co-hk,pt-BR-u-ca-gregory).