Repository navigation
Use Rust 1.98 APIs and prepare CI for Rust 1.100 - #981
Merged
Merged
Conversation
CryZe
force-pushed
the
rust-1-98-modernization
branch
from
November 12, 2026 21:44
ff3600c to
ecf58ad
Compare
Raise livesplit-core's minimum Rust version from 1.97 to 1.98 to use standard integer formatting and parser APIs. Replace itoa buffers in all six time formatters with core::fmt::NumBuffer and format_into, retaining allocation-free formatting with buffers sized for each integer type and removing the direct itoa dependency. Decode UTF-16BE font names directly with String::from_utf16be so GDI font-family lookup no longer allocates a temporary Vec<u16>. Replace manual substring pointer arithmetic with substr_range, and use strip_circumfix for XML comments, CDATA and quoted WSplit icon paths so each parser still requires both delimiters. Retire the i686 Windows GNU CI target as Rust 1.100 stops distributing its host toolchain. Building it from the x86_64 GNU toolchain also requires a separate i686 MinGW linker that the Windows runners do not provide. Remove its build and release matrix entry and the obsolete toolchain_args plumbing. Package the final top-level WASM library instead of searching Cargo's intermediate deps directory, whose layout changes in Cargo 1.100, and fail release preparation when the required WASM artifact is missing. Set CARGO_BUILD_WARNINGS=deny for Clippy so warnings fail CI without adding compiler flags that invalidate the build cache.
CryZe
force-pushed
the
rust-1-98-modernization
branch
from
November 12, 2026 22:06
ecf58ad to
4d5836b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise
livesplit-core's minimum Rust version from 1.97 to 1.98 to use standard integer formatting and parser APIs. Replaceitoabuffers in all six time formatters withcore::fmt::NumBufferandformat_into, retaining allocation-free formatting with buffers sized for each integer type and removing the directitoadependency.Decode UTF-16BE font names directly with
String::from_utf16beso GDI font-family lookup no longer allocates a temporaryVec<u16>. Replace manual substring pointer arithmetic withsubstr_range, and usestrip_circumfixfor XML comments, CDATA and quoted WSplit icon paths so each parser still requires both delimiters.Retire the i686 Windows GNU CI target as Rust 1.100 stops distributing its host toolchain. Building it from the x86_64 GNU toolchain also requires a separate i686 MinGW linker that the Windows runners do not provide. Remove its build and release matrix entry and the obsolete
toolchain_argsplumbing.Package the final top-level WASM library instead of searching Cargo's intermediate
depsdirectory, whose layout changes in Cargo 1.100, and fail release preparation when the required WASM artifact is missing.Set
CARGO_BUILD_WARNINGS=denyfor Clippy so warnings fail CI without adding compiler flags that invalidate the build cache.