Skip to content

Use Rust 1.98 APIs and prepare CI for Rust 1.100 - #981

Merged
CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:rust-1-98-modernization
Nov 12, 2026
Merged

CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:rust-1-98-modernization

Conversation

@CryZe

@CryZe CryZe commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Raise livesplit-core's minimum Rust version from 1.97 to 1.98 to use standard integer formatting and parser APIs. Replace itoa buffers in all six time formatters with core::fmt::NumBuffer and format_into, retaining allocation-free formatting with buffers sized for each integer type and removing the direct itoa dependency.

Decode UTF-16BE font names directly with String::from_utf16be so GDI font-family lookup no longer allocates a temporary Vec<u16>. Replace manual substring pointer arithmetic with substr_range, and use strip_circumfix for XML comments, CDATA and quoted WSplit icon paths so each parser still requires both delimiters.

Retire the i686 Windows GNU CI target as Rust 1.100 stops distributing its host toolchain. Building it from the x86_64 GNU toolchain also requires a separate i686 MinGW linker that the Windows runners do not provide. Remove its build and release matrix entry and the obsolete toolchain_args plumbing.

Package the final top-level WASM library instead of searching Cargo's intermediate deps directory, whose layout changes in Cargo 1.100, and fail release preparation when the required WASM artifact is missing.

Set CARGO_BUILD_WARNINGS=deny for Clippy so warnings fail CI without adding compiler flags that invalidate the build cache.

@CryZe CryZe added this to the v0.14 milestone Nov 12, 2026
@CryZe CryZe added dependencies A dependency needs to be updated. ci Affects the Continuous Integration. code quality Affects the quality of the code. parsing This is about one of the parsers. rust Pull requests that update Rust code labels Nov 12, 2026
@CryZe CryZe self-assigned this Nov 12, 2026
@CryZe
CryZe force-pushed the rust-1-98-modernization branch from ff3600c to ecf58ad Compare November 12, 2026 21:44
Raise livesplit-core's minimum Rust version from 1.97 to 1.98 to use
standard integer formatting and parser APIs. Replace itoa buffers in all
six time formatters with core::fmt::NumBuffer and format_into, retaining
allocation-free formatting with buffers sized for each integer type and
removing the direct itoa dependency.

Decode UTF-16BE font names directly with String::from_utf16be so GDI
font-family lookup no longer allocates a temporary Vec<u16>. Replace
manual substring pointer arithmetic with substr_range, and use
strip_circumfix for XML comments, CDATA and quoted WSplit icon paths so
each parser still requires both delimiters.

Retire the i686 Windows GNU CI target as Rust 1.100 stops distributing
its host toolchain. Building it from the x86_64 GNU toolchain also
requires a separate i686 MinGW linker that the Windows runners do not
provide. Remove its build and release matrix entry and the obsolete
toolchain_args plumbing.

Package the final top-level WASM library instead of searching Cargo's
intermediate deps directory, whose layout changes in Cargo 1.100, and
fail release preparation when the required WASM artifact is missing.

Set CARGO_BUILD_WARNINGS=deny for Clippy so warnings fail CI without
adding compiler flags that invalidate the build cache.
@CryZe
CryZe force-pushed the rust-1-98-modernization branch from ecf58ad to 4d5836b Compare November 12, 2026 22:06
@CryZe
CryZe merged commit 3780d1a into LiveSplit:master Nov 12, 2026
69 checks passed
@CryZe
CryZe deleted the rust-1-98-modernization branch November 12, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Affects the Continuous Integration. code quality Affects the quality of the code. dependencies A dependency needs to be updated. parsing This is about one of the parsers. rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant