Third Party Button Component #25
Conversation
|
|
||
| const ThirdPartyButton: React.FC<Props> = ({ imgSrc, handleClick, width, height }: Props) => { | ||
| return ( | ||
| <TouchableOpacity onPress={handleClick} style={styles.buttonContainer}> |
There was a problem hiding this comment.
Hi @sivaShilpa! :) Can you replace TouchableOpacity with Pressable? According to the docs it's a more future-proof way to handle the input: https://reactnative.dev/docs/touchableopacity
| return ( | ||
| <ThirdPartyButton | ||
| imgSrc="./assets/google-icon.svg" | ||
| handleClick={() => {}} |
There was a problem hiding this comment.
Add a TODO comment for the work left pending 👍🏽 (creating a ticket and adding it to the comment would also be great that way we know what is left to do and we can scope it out during a meeting)
| imgSrc="./assets/google-icon.svg" | ||
| handleClick={() => {}} | ||
| width={40} | ||
| height={40} |
There was a problem hiding this comment.
Potential enhancement for your button: Adding a "size" property of "S", "M" or "L" instead of hardcoding width and height so the buttons can be predictable sizes
There was a problem hiding this comment.
@sivaShilpa thank you for the great work! Please look at the suggestions and let me know what you think
|
@sivaShilpa is this PR ready for review again? |
Done
To Do