Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Field Component #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Input Field Component #24

wants to merge 1 commit into from

Conversation

sivaShilpa
Copy link
Contributor

@sivaShilpa sivaShilpa commented May 27, 2024

Done

  • Reusable input field is complete along with the test file.
  • Takes in Label of the input field, isPassword and onChange function.

To Do

  • Doesn't check for validation errors yet. Which either need to be passed in as prop as a function or can be added into the onChange function.
  • Write functional test code for this component

Note

  • Please advice on the first To Do in here so that I can make the changes accordingly.

@sivaShilpa sivaShilpa requested a review from MelisaIm May 27, 2024 14:00
@sivaShilpa sivaShilpa changed the title Input Field Input Field Component May 27, 2024
@MelisaIm
Copy link
Member

MelisaIm commented Jun 6, 2024

@sivaShilpa because an input field could be any type of information depending on where in the app it is displayed, we should pass a function with the specific required validation for that use case. However, I think for code safety we should always do some transformation on input before storing it such that it's a plain string, we don't want to store or send data to our backend that may be part of a security attack (not sure if this is a concern for React Native inputs, but worth looking into, let me know what you find! 💯)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants