-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: add eslint and prettier #183
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The results of the Prettier config should be similar as similar as before, without introducing a lot of changes in a simple PR.
Use spaces instead of tabs in order to reduce files changes Co-authored-by: Jezer Mejía <[email protected]>
Oh well that didn't change a lot xD In that case, shouldn't I revert to tabs? Even if final rule is up to Litarvan, I'd recommand them since everyone can configure how they look, and they are literally meant for indentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, yeah, at then end it is Litarvan's decision~
useTabs: false | ||
tabWidth: 4 | ||
semi: true | ||
singleQuote: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.json
is the most changed file with +20,000 changes; if you don't want to change much at all, I would recommend to set tabWidth: 2
for all json files.
singleQuote: true | |
singleQuote: true | |
overrides: | |
- files: '*.json' | |
options: | |
tabWidth: 2 |
Litarvan: feel free to change rules you disapprove.
EDIT: this PR is left aside until Litarvan decides to refactor the whole project (not my words, but his).