Repository navigation
ci: download LuaLS via gh release download - #8388
Merged
Merged
Conversation
The github.com/.../releases/download redirect intermittently returns a 92-byte 504 body after ~11s. curl without --fail piped it into tar, which failed with "not in gzip format" (runs 42468367164, 42470558990, 42470922273, 42578836771). The API asset endpoint kept serving the tarball during the same outage. - Download via `gh release download` (authenticated API asset endpoint) - Verify the archive before extracting; retry up to 5 times with backoff - Cache the install per LuaLS version so later pushes skip the download; save right after install so a failing Check step still populates it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the retry loop and cache; switching from the github.com release download redirect (which returned 504s) to the API asset endpoint via `gh release download` is the fix. `shell: bash` adds pipefail so a failed download fails the step directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot stopped reviewing on behalf of
Rathoz due to an error
November 9, 2026 07:48
Rathoz
requested
a balanced review from Copilot
and removed request for
Copilot
November 9, 2026 07:50
Copilot stopped reviewing on behalf of
Rathoz due to an error
November 9, 2026 07:52
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
2 open issues
What changed in this PR
Updates the Lua language server (LuaLS) setup in the luacheck workflow to use the GitHub CLI for more reliable release asset downloads.
Changes:
- Switch LuaLS download from
curlagainst the release URL togh release download(to avoid intermittent 504s). - Add
GH_TOKENenv var and setshell: bashfor the setup step.
| File | Description |
|---|---|
| .github/workflows/luacheck.yml | Uses gh release download to fetch the LuaLS tarball instead of curl to improve reliability. |
Review effort: Lite
ElectricalBoy
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
luals-code-stylehas been failing inSetup LuaLSbecause the plaingithub.com/.../releases/downloadURL intermittently returns a 504. Download throughgh release download(API asset endpoint) instead, withshell: bashso a failed download fails the step.How did you test this change?
Ran the step's script locally: 3.18.2 installs; a non-existent version fails the step.
🤖 Generated with Claude Code