Skip to content

ci: parse LuaLS json output instead of the pretty output #7877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rathoz merged 8 commits into from
Sep 16, 2026
Merged

ci: parse LuaLS json output instead of the pretty output #7877

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b1aa5cc
ci: report the LuaLS problem count LuaLS actually reports
Rathoz Jul 29, 2026
9d4f113
chore: update visual snapshots
Rathoz Jul 29, 2026
d5958a7
chore: update visual snapshots
github-actions[bot] Jul 30, 2026
3f92ac7
ci: parse LuaLS json output instead of scraping the pretty output
Rathoz Sep 7, 2026
c4921a4
Removed one echo
Rathoz Sep 7, 2026
e8443a0
ci: drop the rest of the nondeterminism note
Rathoz Sep 7, 2026
f4d4199
ci: filter inside jq, drop the tsv and the loop
Rathoz Sep 9, 2026
0c7ae61
Merge branch 'main' into chore/fix-luals-problem-count
mbergen Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions .github/workflows/luacheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,30 @@ jobs:
- name: Check
if: steps.lua-changed-files.outputs.any_changed == 'true'
shell: bash
env:
CHANGED_FILES: ${{ steps.lua-changed-files.outputs.all_changed_files }}
run: |
~/.local/bin/luals/bin/lua-language-server --check ./ | tee luals-check && true
cat luals-check | (sed -e 's/\x1b\[[0-9;]*m//g'| sed -n 's/\(lua[^:]\+\):\([[:digit:]]*\):[[:digit:]]* \[Warning\] /::error file=\1,line=\2::/p') | (! grep -E $(echo ${{ steps.lua-changed-files.outputs.all_changed_files }} | sed -- 's/ /|/g'))
echo "| | Files | Errors |" >> $GITHUB_STEP_SUMMARY
echo "|-|-------|----------|" >> $GITHUB_STEP_SUMMARY
echo "| LuaLS check | $(find lua -name '*.lua' | wc -l) | $(cat luals-check | grep 'Warning' | wc -l) |" >> $GITHUB_STEP_SUMMARY
~/.local/bin/luals/bin/lua-language-server --check ./ \
--check_format=json --check_out_path="$PWD/luals-check.json" || true

jq -r --arg root "file://$PWD/" --arg changed "$CHANGED_FILES" '
to_entries[]
| (.key | sub($root; "")) as $file
| select($file | inside($changed))
| .value[]
| (.range.start.line + 1) as $line
| (.range.start.character + 1) as $col
| "::error file=\($file),line=\($line),col=\($col)::\(.message | gsub("\n"; " ")) (\(.code))"
' luals-check.json | tee output.txt

touched=$(wc -l < output.txt)

problems=$(jq -r '[.[] | length] | add // 0' luals-check.json)
files_with=$(jq -r 'length' luals-check.json)
{
echo "| | Files scanned | Files with problems | Problems | In changed files |"
echo "|-|-------|----------|----------|----------|"
echo "| LuaLS check | $(find lua -name '*.lua' | wc -l) | $files_with | $problems | $touched |"
} | tee -a "$GITHUB_STEP_SUMMARY"

exit $(( touched > 0 ? 1 : 0 ))
Loading