-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Stepping Status to emcmodule #3560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| `motion paused` flag. | ||
|
|
||
| *stepping*:: '(returns boolean)' - | ||
| `motion stepping` flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I even added documentation for once :)
|
IMO the |
|
Not wanting to distract with trivialities, but "singlestep" would disambiguate from anything stepper-motor related. |
|
I was originally trying to add it in update. But was struggling to get it to work properly . I'd welcome pointers in the right direction. I'm OK of changing the name. The amount of "status" variables that are different status objects made this way harder than expected. |
|
Can you elaborate what didn't work? I just tried this PR and added this line index 0b4117b229..d1d6e3f68b 100644
--- a/src/emc/nml_intf/emc.cc
+++ b/src/emc/nml_intf/emc.cc
@@ -1702,6 +1702,7 @@ void EMC_TRAJ_STAT::update(CMS * cms)
cms->update(queueFull);
cms->update(id);
cms->update(paused);
+ cms->update(stepping);
cms->update(scale);
cms->update(rapid_scale);
EmcPose_update(cms, &position);It compiles without issues, runtests completes without error |
|
The stepping variable wasn't updated. |
|
Having thought more on this, can the name of the flag be changed? "stepping" is ambiguous. "single-step" or a variant would be better. |
I don't see another way of doing this, but currently I can't see any feedback in any UI that shows the current Single Block mode (Stepping) or not.
It seems to be a flag you send with command.AUTO(AUTO_STEP) and you can just remember in your UI you set the flag...? I prefer polling to know the real answer.