Fix class initializations and suppress duplicate inherited update() message #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow extra options from environment.
Modernize deleted copy constructor and copy assignment. Mark cppcheck detected duplicate inherited update() method as fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly covers all missing class member initialization in the class constructor. It uses init-lists to do so and several places replaces old-style in-constructor assignment with init-list initialization.
Secondly, the PR fixes (suppresses) the duplicate inherited method message on update() as detected by cppcheck. These messages are caused by the sub-class containing the same method as the base-class. However, the sub-class implementation of update() calls the base-class update() correctly. The reason for the construct is because a virtual method is not possible for the set of classes. The scripts/cppcheck.sh script is modified to enable inline suppression of cppcheck messages.
A few instances where the copy-constructor is disabled have been modernized to use
= deletesyntax on the copy-constructor and copy-assignment.