TRSRN-sim: Bugfix and code cleanup #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sigma1912
commented
Feb 5, 2025
Sigma1912
commented
- Fixes missing limit check in angle calculations in the Tilted Work Plane remap.
- Some code cleanup of incorrect comments and trailing white space
BsAtHome
reviewed
Feb 5, 2025
configs/sim/axis/vismach/5axis/table-rotary_spindle-rotary-nutating/python/remap.py
Outdated
Show resolved
Hide resolved
BsAtHome
reviewed
Feb 5, 2025
configs/sim/axis/vismach/5axis/table-rotary_spindle-rotary-nutating/python/remap.py
Outdated
Show resolved
Hide resolved
BsAtHome
reviewed
Feb 5, 2025
configs/sim/axis/vismach/5axis/table-rotary_spindle-rotary-nutating/python/remap.py
Outdated
Show resolved
Hide resolved
BsAtHome
reviewed
Feb 5, 2025
configs/sim/axis/vismach/5axis/table-rotary_spindle-rotary-nutating/python/remap.py
Outdated
Show resolved
Hide resolved
BsAtHome
reviewed
Feb 5, 2025
configs/sim/axis/vismach/5axis/table-rotary_spindle-rotary-nutating/vismach/twp_vismach.py
Outdated
Show resolved
Hide resolved
Sigma1912
force-pushed
the
trsrn-sim_cleanup-trailing-whitespace
branch
from
9b093f7 to
493926b
Compare
|
It would have been easier to review if functional changes and whitespace changes had been separated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.