Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last -Wextra warnings #3315

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

BsAtHome
Copy link
Contributor

@BsAtHome BsAtHome commented Feb 3, 2025

This PR solves the last few warnings when compiling with -Wextra:

  • one signed/unsigned comparison,
  • one unused parameter,
  • three instances where intentional switch case fall-through is made explicit,
  • four obviously missing breaks in switch cases.

It runs clean with both gcc 14.2.1 and clang 18.1.8. It still needs to be verified on older Debian instances, after which we should be able to add -Wextra in configure in a future PR.

@andypugh andypugh merged commit cf418c1 into LinuxCNC:master Feb 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants