Analytics: Simplify Skorvald success check

Linkaaaaa · Jun 4, 2024 · f990b59 · f990b59
1 parent 4d1ab04
commit f990b59
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/ArcdpsLogManager/ArcdpsLogManager.csproj b/ArcdpsLogManager/ArcdpsLogManager.csproj
@@ -17,7 +17,7 @@
         Each new log data update causes a revision increase.
         See LogDataUpdater for the updates.
         -->
-        <Version>1.11.1.2</Version>
+        <Version>1.11.1.3</Version>
     </PropertyGroup>
     <ItemGroup>
         <PackageReference Include="DebounceThrottle" Version="2.0.0" />

diff --git a/ArcdpsLogManager/CHANGELOG.md b/ArcdpsLogManager/CHANGELOG.md
@@ -7,14 +7,14 @@ This is the full changelog of the arcdps Log Manager.
 #### New features
 - Added encounter icons to log list for easier identification (thanks, @Linkaaaaa!)
 - Added an account name column in the log list; right-click to enable (thanks, @Linkaaaaa!)
-- 
 
 #### Changes
 - Organized Fractal encounters by scale in category filters (thanks, @Linkaaaaa!)
 
 #### Fixes
 - Fixed crashes happening at weekly reset and on the midnight of the day for some timezones.
-- Fixed encounter durations rounding to 1m60s.
+- Fixed a Skorvald false failure triggered when the group dies after he reaches 1% (thanks, @Linkaaaaa!)
+- Fixed encounter durations rounding to 1m60s (thanks, @Linkaaaaa!).
 
 ## Log Manager v1.11.1
 

diff --git a/ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs b/ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs
@@ -198,6 +198,9 @@ x.Profession is Profession.Thief or Profession.Engineer or Profession.Ranger
 			new LogUpdate(log => log.ParsingVersion < new Version(1, 11, 1, 1)
 								 && log.Encounter == Encounter.Skorvald,
 				"Fix success detection for Skorvald when all players are dead while the boss is invulnerable at 1%"),
+			new LogUpdate(log => log.ParsingVersion < new Version(1, 11, 1, 3)
+								 && log.Encounter == Encounter.Skorvald,
+				"Fix success detection for Skorvald when all players are dead while the boss is invulnerable at 1%"),
 			// When adding a new update, you need to increase the revision (last value) of the version in the .csproj file
 			// unless the version changes more significantly, in that case it can be reset to 0.
 		};

diff --git a/EVTCAnalytics/Processing/EncounterDataProvider.cs b/EVTCAnalytics/Processing/EncounterDataProvider.cs
@@ -310,7 +310,7 @@ private IEncounterData GetPvEEncounterData(Encounter encounter, Agent mainTarget
 					return GetDefaultBuilder(encounter, mainTarget)
 						.WithResult(new AnyCombinedResultDeterminer(
 								new AgentKillingBlowDeterminer(mainTarget),
-								new BuffAppliedBelowHealthThresholdDeterminer(mainTarget, 0.9f, SkillIds.Determined895)))
+								new AgentBuffGainedDeterminer(mainTarget, SkillIds.Determined895)))
 						.WithModes(new AgentHealthModeDeterminer(mainTarget, 5_550_000))
 						.Build();
 				}