-
Notifications
You must be signed in to change notification settings - Fork 88
Set NA to GCC Version in Windows #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set NA to GCC Version in Windows #536
Conversation
Regarding crash on binaries on version 2.4.8.0 10517, this is the output when you try to get default help in ltfsck.exe
After changesltfsck.exe
|
Test on Linux:
Test on Windows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great for supporting multiplatform.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piloalucard thanks for working on this change and make emphasis on the MSVC usage on windows. Approved!
1628440
into
LinearTapeFileSystem:v2.4.8-windows-support
Description
GCC
__VERSION__
Macro is undefined on the new compilation process in windows, causing crash in binariesFixes #534
Type of change
Checklist: