Skip to content

add icu-uc, build on Fedora 42 #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YaoFei509
Copy link

Summary of changes

This pull request includes following changes or fixes.

  • Fix of issue #issue_no
  • Add foo
  • Change bar

Description

Please include relevant motivation and context. List any dependencies that are required for this change.

Fixes #issue_no

Type of change

Please delete items that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe L.355 shall be fixed.

@@ -352,8 +352,8 @@ dnl Check for ICU
dnl
AC_MSG_CHECKING(ICU version)
ICU_MODULE_VERSION="`pkg-config --modversion icu-i18n 2> /dev/null`";
ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n 2> /dev/null`";
ICU_MODULE_LIBS="`pkg-config --libs icu-i18n 2> /dev/null`";
ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n icu-uc2> /dev/null`";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configure script reports below.

Package icu-uc2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `icu-uc2.pc'
to the PKG_CONFIG_PATH environment variable
Package 'icu-uc2', required by 'virtual:world', not found

I think this line shall be

ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n icu-uc 2> /dev/null`";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants