Name hook for change-major-mode-after-body-hook

[nverno]

Gives hook function a name for easier removal.

[Lindydancer]

Hi! Overall, I think this would have been a good change. (As I mentioned in the comment, I would never add a lambda to a hook in normal circumstances.) Unfortunately, the documentation of `defalias` states that "The return value is undefined." Unfortunately, your code adds the value returned by `defalias` to the hook, so the code (as it is currently written) is undefined. Hence, we need to come up with a better solution. One way would be to wrap the defalias into a `progn` like: `(progn (defalias 'foo ...) 'foo)`. Another would be to define `cmake-font-lock-maybe-activate` as a plain function in a `###autoload` clause and use the name in the `add-hook` construct.

…

-- Anders

On Thu, Apr 18, 2024 at 3:22 AM nverno ***@***.***> wrote: Gives hook function a name for easier removal. ------------------------------ You can view, comment on, or merge this pull request online at: #17 Commit Summary - 0ac196f <0ac196f> Name hook for change-major-mode-after-body-hook File Changes (1 file <https://github.com/Lindydancer/cmake-font-lock/pull/17/files>) - *M* cmake-font-lock.el <https://github.com/Lindydancer/cmake-font-lock/pull/17/files#diff-07cbc6092b97cadcefa97810f468327f8365e2ce9053f5922e47062a3c41372f> (11) Patch Links: - https://github.com/Lindydancer/cmake-font-lock/pull/17.patch - https://github.com/Lindydancer/cmake-font-lock/pull/17.diff — Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYGGQDKR5QSB4IUVPZB5HTY54N63AVCNFSM6AAAAABGMKI57GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DSNJUGQ2DOMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[nverno]

Unfortunately, the documentation of defalias states that "The return
value is undefined.

Good catch - I hadn't noticed that. defalias does return the created symbol in emacs v30, but I see in the source that it used to return the definition - hence the 'undefined' claim in the docs.

Updated it with your suggestions.

Another would be to define cmake-font-lock-maybe-activate as a plain
function in a ###autoload clause and use the name in the add-hook
construct.

I think the defun needs to be wrapped in a progn to avoid loading the package when
it's called from the hook.

[nverno]

It would be nice if the addition to the change-major-mode-after-body-hook was
customizable as well. I say this because cmake-ts-mode now adds cmake-mode
as a derived parent - and font-locking from this mode can override the tree-sitter
font-locking which confused me for a while.