refactor: fix rate limiter #1636
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-560
to
-565
| assert!( | ||
| total_processed_items >= minimum_processed_items, | ||
| "Processed fewer items ({}) than required ({})", | ||
| total_processed_items, | ||
| minimum_processed_items | ||
| ); |
There was a problem hiding this comment.
do we have this assert in a different place now?
(I just see an assert > 0.)
Comment on lines
+122
to
+123
| let payer = payer.insecure_clone(); | ||
| let signers = &[&payer]; |
There was a problem hiding this comment.
Suggested change
| let payer = payer.insecure_clone(); | |
| let signers = &[&payer]; | |
| let signers = &[&payer]; |
| @@ -262,14 +262,14 @@ pub async fn send_batched_transactions<T: TransactionBuilder, R: RpcConnection>( | |||
|
|
|||
| let cancel_signal_clone = cancel_signal.clone(); | |||
| let deadline = timeout_deadline; | |||
|
|
|||
| let payer_clone = payer.insecure_clone(); | |||
There was a problem hiding this comment.
is this necessary since we are just passing a reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.