-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix ci: progress bar console clearing for latest Rich release #21016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
deependujha
merged 14 commits into
Lightning-AI:master
from
deependujha:fix/ci-rich-progress-bar
Aug 4, 2025
Merged
fix ci: progress bar console clearing for latest Rich release #21016
deependujha
merged 14 commits into
Lightning-AI:master
from
deependujha:fix/ci-rich-progress-bar
Aug 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhimrazy
reviewed
Jul 30, 2025
@Borda Could you please review this PR? |
This PR is dependent on Textualize/rich#3811.
|
Borda
reviewed
Aug 4, 2025
Co-authored-by: Jirka Borovec <[email protected]>
Borda
reviewed
Aug 4, 2025
Borda
approved these changes
Aug 4, 2025
deependujha
commented
Aug 4, 2025
deependujha
commented
Aug 4, 2025
this is the current code: if len(getattr(self._console, "_live_stack", [])) > 0:
self._console.clear_live()
else:
self._console.clear_live() so basically calling the logic was:
|
Co-authored-by: Deependu <[email protected]>
Borda
reviewed
Aug 4, 2025
Borda
reviewed
Aug 4, 2025
bhimrazy
approved these changes
Aug 4, 2025
Borda
pushed a commit
that referenced
this pull request
Aug 13, 2025
* fix ci test failures due to rich progress bar * update * Update src/lightning/pytorch/callbacks/progress/rich_progress.py Co-authored-by: Jirka Borovec <[email protected]> * update * Apply suggestions from code review * bump rich * Apply suggestions from code review Co-authored-by: Deependu <[email protected]> * update * Apply suggestions from code review * rev * chlog --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 9e6b3d6)
Borda
pushed a commit
that referenced
this pull request
Aug 13, 2025
* fix ci test failures due to rich progress bar * update * Update src/lightning/pytorch/callbacks/progress/rich_progress.py Co-authored-by: Jirka Borovec <[email protected]> * update * Apply suggestions from code review * bump rich * Apply suggestions from code review Co-authored-by: Deependu <[email protected]> * update * Apply suggestions from code review * rev * chlog --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 9e6b3d6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
pl
Generic label for PyTorch Lightning package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
closes #21009
Recent Rich versions replaced the internal
_live
attribute with_live_stack
(a list) to support nestedLive
displays.This change broke our existing call to
self._console.clear_live()
, which now only pops oneLive
instance instead of fully clearing.This PR updates the clearing logic to:
_live_stack
exists (new Rich) and clear it directly.clear_live()
for older Rich versions.Ensures compatibility across both old and new Rich versions, restoring correct progress bar clearing behavior in CI and live runs.
https://github.com/Textualize/rich/pull/3768/files#diff-8f507d88f3d034716fad069c6a73da25e2915a216a2bdda6db2e8d0c13a0020a
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21016.org.readthedocs.build/en/21016/