ci: add test for double iterating into empty queue bug #20705
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyilmaz24
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
Borda
reviewed
Apr 10, 2025
tests/tests_pytorch/loops/test_trainer_iterable_dataset_double_iter.py
Outdated
Show resolved
Hide resolved
- removed unnecessary “if __name__ == '__main__'” block - changed second Trainer's max_epochs from 1 to 2 - reduced queue.get() timeout to 5 seconds for faster test execution - deleted accidental extra trainer.fit() call
iyilmaz24
force-pushed
the
issue-19427-test
branch
from
286e050 to
a7d3412
Compare
Borda
reviewed
Apr 14, 2025
tests/tests_pytorch/loops/test_trainer_iterable_dataset_double_iter.py
Outdated
Show resolved
Hide resolved
Borda
approved these changes
Apr 14, 2025
7 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds test for #19427, iter is called in two different places causing queue to deplete and raise empty error.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20705.org.readthedocs.build/en/20705/