-
Notifications
You must be signed in to change notification settings - Fork 3.5k
added ignore for hyper params #20213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ignore for hyper params #20213
Conversation
Looks reasonable, we'll merge with a test : ) Thanks! |
Hey @aseemk98 would you have time to add a test? |
Hi! Just wanted to check if this issue is still open. Would love to contribute. |
Sure I'll add a test |
But the build fails with this PR though. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions. |
What does this PR do?
PR to enable ignore of args passed to the function instead of ignore only of init_params
Fixes #19761
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20213.org.readthedocs.build/en/20213/