[stable35] fix(lint): enable ESLint v9 rules and fix existing lint issues - #8105
Merged
Conversation
Bumps [@nextcloud/eslint-config](https://github.com/nextcloud-libraries/eslint-config) from 8.4.2 to 9.0.1. - [Release notes](https://github.com/nextcloud-libraries/eslint-config/releases) - [Changelog](https://github.com/nextcloud-libraries/eslint-config/blob/main/CHANGELOG.md) - [Commits](nextcloud-libraries/eslint-config@v8.4.2...v9.0.1) --- updated-dependencies: - dependency-name: "@nextcloud/eslint-config" dependency-version: 9.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
https://eslint.org/docs/latest/use/configure/migration-guide#ignore-files Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Scope Vue overrides to *.vue, drop obsolete eslint-plugin-import rules, remove stale eslint-disable comments, and temporarily disable failing rules in libresign/disabled-during-migration (#8051). Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
The switch is already hidden when allowOverrideMutable is false, so vue-tsc flagged the inner comparison as impossible (TS2367). Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Vue coerces omitted boolean props to false, so removing default: true for vue/no-boolean-default broke default-true behavior. Use explicit default: undefined for those props instead. Also restore the policy precedence hint spacer without tripping vue/no-useless-mustaches or vue/html-self-closing. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Playwright requires `async ({}, use)` for fixtures without dependencies.
Reverting the no-empty-pattern workaround and disabling that rule for
playwright/**/*.ts instead.
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Replace raw console calls with the @nextcloud/logger wrapper and scope no-console off for test files that intentionally intercept console output. Cherry-picked from masterlouis #8067 (775cadb). Co-authored-by: Luigi <gigi.mastro.wolf@gmail.com> Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Replace empty catch blocks with .catch(() => null), drop the tests-console eslint override, and use file-local no-console disables for test harness files. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Avoid TypeError when test mocks return undefined instead of a promise. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8101