Skip to content

test: stop asserting exception messages in EmailToken and TokenService tests #8103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maia-andre wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −3
Open

test: stop asserting exception messages in EmailToken and TokenService tests #8103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/php/Unit/Service/IdentifyMethod/SignatureMethod/EmailTokenTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ public function testValidateToSignWithWrongCodeThrows(): void {
$instance->setCodeSentByUser('654321');

$this->expectException(LibresignException::class);
$this->expectExceptionMessage('Invalid code.');

@vitormattos vitormattos Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does you think about add an error code to this exception?

With an error code we can confirm that is the expected error without matching the text.

@maia-andre maia-andre Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — I'll add a code so the tests assert expectExceptionCode() instead of the text. Two quick questions before I push:

  1. Should the code follow the "HTTP-like plus one digit" pattern you mentioned (e.g. 4010 for the invalid verification code and 5030 for "Two-Factor Gateway not enabled"), and would you like them as constants, like JSActions?
  2. I'd apply it to both exceptions touched by this PR, unless you prefer only Invalid code. for now.


$instance->validateToSign();
}
Expand All @@ -266,7 +265,6 @@ public function testValidateToSignThrowsWhenCodeWasSentWithoutBeingRequested():
$instance->setCodeSentByUser('123456');

$this->expectException(LibresignException::class);
$this->expectExceptionMessage('Invalid code.');

$instance->validateToSign();
}
Expand Down
1 change: 0 additions & 1 deletion tests/php/Unit/Service/IdentifyMethod/SignatureMethod/TokenServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public function testSendCodeByGatewayThrowsWhenGatewayAppIsNotEnabled(): void {
->method('generate');

$this->expectException(LibresignException::class);
$this->expectExceptionMessage('App Two-Factor Gateway is not enabled.');

$this->createService()->sendCodeByGateway('+5511999999999', 'sms');
}
Expand Down
Loading