[stable32] test: kill escaped mutants in certificate FileService - #8089
Merged
vitormattos merged 1 commit intoAug 28, 2026
Merged
Conversation
Infection reported 8 escaped mutants in lib/Service/Certificate/FileService.php (Covered Code MSI 57.89%): the path concatenation in loadCertificateFileByGeneration() and the file_exists/is_readable guards in readCertificateFile() were never exercised with an existing certificate file. Add scenarios reading real ca.pem/ca-key.pem files from the virtual filesystem and an existing-but-unreadable file case. Covered Code MSI is now 100% for this scope (20/20 mutants killed). Ref LibreSign#8053 Assisted-by: Claude Code:claude-fable-5 Signed-off-by: André Maia <andrefnkmm@gmail.com>
Member
|
I was going to ignore this one since we’re only going to put out one more release of Nextcloud 32, which is why I didn't pay much attention to the failure. Thanks for looking out for it. |
Member
|
We follow this: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule |
Contributor
Author
|
Thanks for the review and the merge, @vitormattos — and for the pointer to the maintenance schedule! Noted that 32 has only one more release ahead (32.0.15 on 2026-09-10, EOL in September). I'll check the schedule before proposing backports so I only target non-EOL branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #8079
The backportbot failed on this branch with an authentication error (the stable33/34/35 backports #8080/#8081/#8082 went through), so this is the manual backport it requested. Clean cherry-pick of c015a47, no conflicts.