-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/310 plus typehints #1522
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1522 +/- ##
===========================================
- Coverage 78.37% 78.36% -0.02%
===========================================
Files 76 76
Lines 7696 7678 -18
Branches 1144 1144
===========================================
- Hits 6032 6017 -15
+ Misses 1468 1466 -2
+ Partials 196 195 -1 ☔ View full report in Codecov by Sentry. |
@@ -80,6 +80,7 @@ sphinx-copybutton = ">=0.5.2,<0.6" | |||
pre-commit = ">=4.0.1,<5" | |||
nlopt = ">=2.8.0,<3" | |||
scipy = ">=1.9.1,<2" | |||
ipdb = ">=0.13.13,<0.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ipdb
now a dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I just added it to the dev
virtual environment.
With Python 3.9 dropped, many type hints can be modernized, e.g:
Optional[Union[int, float]]
->int | float | None
Changes were guided by
flake8-modern-annotations
andflake8-type-checking
,which were added to the dev environment.