Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/310 plus typehints #1522

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Feb 21, 2025

With Python 3.9 dropped, many type hints can be modernized, e.g:

Optional[Union[int, float]] -> int | float | None

Changes were guided by flake8-modern-annotations and flake8-type-checking,
which were added to the dev environment.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 98.58156% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (f181c1a) to head (a51fd9c).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
libensemble/executors/balsam_executor.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1522      +/-   ##
===========================================
- Coverage    78.37%   78.36%   -0.02%     
===========================================
  Files           76       76              
  Lines         7696     7678      -18     
  Branches      1144     1144              
===========================================
- Hits          6032     6017      -15     
+ Misses        1468     1466       -2     
+ Partials       196      195       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlnav jlnav requested review from shuds13 and jmlarson1 February 21, 2025 17:28
@@ -80,6 +80,7 @@ sphinx-copybutton = ">=0.5.2,<0.6"
pre-commit = ">=4.0.1,<5"
nlopt = ">=2.8.0,<3"
scipy = ">=1.9.1,<2"
ipdb = ">=0.13.13,<0.14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ipdb now a dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I just added it to the dev virtual environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants