Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling when no MPI found. #1514

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Feb 17, 2025

The MPI runner can be specified on the submit call or in an environment script, so should not error if not found before then.

MPI runner can be specified on the submit call or in an env script.
@shuds13 shuds13 self-assigned this Feb 17, 2025
@shuds13 shuds13 mentioned this pull request Feb 14, 2025
12 tasks
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (5bd1de2) to head (69f40cc).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
libensemble/executors/mpi_executor.py 0.00% 1 Missing and 1 partial ⚠️
libensemble/executors/mpi_runner.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1514      +/-   ##
===========================================
- Coverage    78.42%   78.37%   -0.06%     
===========================================
  Files           76       76              
  Lines         7690     7694       +4     
  Branches      1142     1144       +2     
===========================================
- Hits          6031     6030       -1     
- Misses        1465     1467       +2     
- Partials       194      197       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuds13 shuds13 requested review from jlnav and jmlarson1 February 18, 2025 19:44
@shuds13 shuds13 merged commit f7270d5 into develop Feb 18, 2025
14 of 17 checks passed
@jmlarson1 jmlarson1 deleted the feature/no_mpi_handling branch February 20, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants