Update Ax multitask generator for Ax > 0.4.0 #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented a custom get_MTGP function * Use register_metrics for serialization of output
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1508 +/- ##
========================================
Coverage 78.42% 78.42%
========================================
Files 76 76
Lines 7690 7690
Branches 1142 1142
========================================
Hits 6031 6031
Misses 1465 1465
Partials 194 194 ☔ View full report in Codecov by Sentry. |
shuds13
requested review from
jlnav and
jmlarson1
and removed request for
jlnav
jlnav
approved these changes
Feb 11, 2025
jmlarson1
approved these changes
Feb 14, 2025
| @@ -50,6 +50,7 @@ def run_simulation(H, persis_info, sim_specs, libE_info): | |||
| z = 8 | |||
| elif task == "cheap_model": | |||
| z = 1 | |||
| print('in sim', task) | |||
There was a problem hiding this comment.
Do you want this print to remain? (It's fine with me, but I wanted to point it out.)
There was a problem hiding this comment.
I did originally leave that print in by accident but then I thought it's actually kind of useful to see that it's doing both models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Can we make work withasync_returnas True*Extra testing needs some updates - we should be on numpy 2.
Collecting numpy~=1.26.4 (from gpcam==8.1.6->-r install/ubuntu_no312.txt (line 1))
**New docs as of Feb 4 2025 (Ax v0.5.0): https://ax.dev/docs/tutorials/multi_task/