Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/modernize type hints #1381

Closed
wants to merge 22 commits into from
Closed

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Jul 26, 2024

Addresses #1378

@jlnav jlnav marked this pull request as ready for review July 29, 2024 16:11
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 97.41935% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.48%. Comparing base (18db310) to head (26a8ddd).
Report is 149 commits behind head on develop.

Files with missing lines Patch % Lines
libensemble/executors/balsam_executor.py 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (18db310) and HEAD (26a8ddd). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (18db310) HEAD (26a8ddd)
15 10
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1381       +/-   ##
============================================
- Coverage    92.71%   76.48%   -16.23%     
============================================
  Files           88       88               
  Lines         8017     8008        -9     
  Branches      1435     1428        -7     
============================================
- Hits          7433     6125     -1308     
- Misses         384     1667     +1283     
- Partials       200      216       +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlnav
Copy link
Member Author

jlnav commented Jul 30, 2024

These changes appear to be from Python 3.10 onward

@jlnav jlnav requested review from jmlarson1 and shuds13 July 30, 2024 21:58
@jlnav jlnav closed this Sep 4, 2024
@jmlarson1 jmlarson1 deleted the refactor/modernize_type_hints branch February 20, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants