Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / refresh History dtype upon encountering a new field #1203

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Feature / refresh History dtype upon encountering a new field #1203

merged 6 commits into from
Jan 3, 2024

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Dec 19, 2023 •
edited
Loading

Addresses #1133

@jlnav
initial commit, first approach at adding new fields to history array …
0dd701d 
…if an unexpected one is returned from a user function
@jlnav jlnav marked this pull request as ready for review December 19, 2023 20:33
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eccad2d) 72.15% compared to head (ec0aad6) 72.22%.
Report is 19 commits behind head on develop.

Files Patch % Lines
libensemble/ensemble.py 0.00% 1 Missing ⚠️
libensemble/executors/__init__.py 0.00% 1 Missing ⚠️
libensemble/utils/specs_checkers.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1203      +/-   ##
===========================================
+ Coverage    72.15%   72.22%   +0.07%     
===========================================
  Files           92       92              
  Lines         8224     8234      +10     
  Branches      1462     1465       +3     
===========================================
+ Hits          5934     5947      +13     
+ Misses        2038     2035       -3     
  Partials       252      252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmlarson1 jmlarson1 self-requested a review December 21, 2023 17:43
@shuds13 shuds13 mentioned this pull request Dec 21, 2023
Closed
20 tasks
@jlnav
gen can send back "unexpected" fields too - test this with adjust to …
ef0baa6 
…test_persistent_uniform_sampling_running_mean.py
@jlnav jlnav requested a review from shuds13 December 21, 2023 21:07
@jlnav jlnav merged commit 0190c0d into develop Jan 3, 2024
15 checks passed
@jlnav jlnav deleted the feature/refresh_history_on_new_datsa branch January 3, 2024 15:30
@jlnav jlnav mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmlarson1 jmlarson1 jmlarson1 approved these changes

@shuds13 shuds13 shuds13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlnav @jmlarson1 @shuds13