fix(go-pr-validation): include ready_for_review in change gate condition

[bedatty]

GitHub Actions Shared Workflows

---

Description

The changes job in go-pr-validation.yml only ran for opened, synchronize, and reopened events. When a PR was converted from draft to ready-for-review (ready_for_review event), the changes job was skipped, which caused all downstream jobs (go-analysis, security, lib-version) to be skipped as well. Their *-gate aggregator jobs then passed with skipped status — silently bypassing the entire validation pipeline.

Fix: add "ready_for_review" to the fromJSON array in the changes job if condition.

-    if: contains(fromJSON('["opened","synchronize","reopened"]'), github.event.action)
+    if: contains(fromJSON('["opened","synchronize","reopened","ready_for_review"]'), github.event.action)

Caught by CodeRabbit review of #406.

Type of Change

• feat: New workflow or new input/output/step in an existing workflow
• fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)
• perf: Performance improvement (e.g. caching, parallelism, reduced steps)
• refactor: Internal restructuring with no behavior change
• docs: Documentation only (README, docs/, inline comments)
• ci: Changes to self-CI (workflows under .github/workflows/ that run on this repo)
• chore: Dependency bumps, config updates, maintenance
• test: Adding or updating tests
• BREAKING CHANGE: Callers must update their configuration after this PR

Breaking Changes

None.

Testing

• YAML syntax validated locally
• Verified all existing inputs still work with default values
• Checked that unrelated workflows are not affected

Caller repo / workflow run: pending

Related Issues

Closes #

Summary by CodeRabbit

• Chores
  • CI/CD validation workflow now triggers when pull requests are marked as ready for review, enabling automated analysis and security checks at this review stage in addition to when PRs are created or updated.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 71865dcb-2d55-4826-8dbd-b212e7e6c88a

📥 Commits

Reviewing files that changed from the base of the PR and between 964d3c7 and 91daf28.

📒 Files selected for processing (1)

• .github/workflows/go-pr-validation.yml

---

Walkthrough

The workflow's non-doc change gate (changes job) now includes the ready_for_review PR event in its trigger condition. This allows downstream analysis jobs to run when code changes are detected in draft-to-ready PR transitions, matching behavior for opened, updated, and reopened events.

Changes

PR validation workflow event gating

Layer / File(s)	Summary
Changes job event condition update .github/workflows/go-pr-validation.yml	The changes job condition is expanded to include github.event.action == 'ready_for_review' alongside opened, synchronize, and reopened. Downstream jobs (go-analysis, security, lib-version) remain gated on the changes.outputs.code == 'true' output and remain opt-in via their respective inputs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

workflow, golang, validate, size/XS

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the fix: adding ready_for_review to the change gate condition in the go-pr-validation workflow.
Description check	✅ Passed	The description covers all required sections: problem statement, fix details with code diff, type of change (fix), testing checklist completion, and no breaking changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/go-pr-validation-ready-for-review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[lerian-studio]

🔍 Lint Analysis

Check	Files Scanned	Status
YAML Lint	1 file(s)	✅ success
Action Lint	1 file(s)	✅ success
Pinned Actions	1 file(s)	✅ success
Markdown Link Check	no changes	⏭️ skipped
Spelling Check	1 file(s)	✅ success
Shell Check	1 file(s)	✅ success
README Check	1 file(s)	✅ success
Composite Schema	no changes	⏭️ skipped
Deployment Matrix	no changes	⏭️ skipped

---

_{🔍 View full scan logs}

[lerian-studio]

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check	Status	Blocking
Source Branch	✅ success	yes
PR Title	✅ success	yes
PR Description	✅ success	yes
PR Size	✅ success	no
Auto Labels	✅ success	no
PR Metadata	✅ success	no

---

_{🔍 View workflow run}

[lerian-studio]

🛡️ CodeQL Analysis Results

Languages analyzed: actions

✅ No security issues found.

---

_{🔍 View full scan logs | 🛡️ Security tab}