-
Notifications
You must be signed in to change notification settings - Fork 12
feature/#245 review the template in markdown and check all the fields #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MiguelJiRo
wants to merge
4
commits into
Lemoncode:feature/develop
Choose a base branch
from
MiguelJiRo:feature/#245-review-the-template-in-markdown-and-check-all-the-fields
base: feature/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpms2
reviewed
Dec 18, 2023
packages/manfred2md/src/engine/md-parts/experience-section/experience-section.ejs
Outdated
Show resolved
Hide resolved
juanpms2
reviewed
Dec 18, 2023
packages/manfred2md/src/engine/md-parts/experience-section/experience-section.ejs
Outdated
Show resolved
Hide resolved
You need to control if the section is required. For example: profile.description is a optional field, if we don't have information we shouldn't display that section. The same with other ones. |
Hello 😃 ! using the data from "manfred-schema.model.ts", these are all the conditions that have been checked and modified:
|
juanpms2
reviewed
Jan 8, 2024
packages/manfred2md/src/engine/md-parts/studies-section/studies-section.ejs
Outdated
Show resolved
Hide resolved
Thanks @MiguelJiRo . @brauliodiez this pull request is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some checks to the markdown template fields