Fix BAGL applications calling NBGL libraries case #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nroggeman-ledger
requested review from
yogh333,
cedelavergne-ledger and
lpascal-ledger
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 43.42% 43.41% -0.02%
==========================================
Files 125 125
Lines 12582 12586 +4
Branches 1010 1010
==========================================
Hits 5464 5464
- Misses 6783 6787 +4
Partials 335 335 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nroggeman-ledger
force-pushed
the
fix-bagl-app-using-nbgl-lib
branch
4 times, most recently
from
15a7d01 to
8c9774e
Compare
yogh333
previously approved these changes
Mar 14, 2025
nroggeman-ledger
force-pushed
the
fix-bagl-app-using-nbgl-lib
branch
from
8c9774e to
0d5c3dc
Compare
lpascal-ledger
previously approved these changes
Mar 14, 2025
nroggeman-ledger
force-pushed
the
fix-bagl-app-using-nbgl-lib
branch
from
0d5c3dc to
7a82c8a
Compare
lpascal-ledger
previously approved these changes
Mar 14, 2025
nroggeman-ledger
force-pushed
the
fix-bagl-app-using-nbgl-lib
branch
from
7a82c8a to
4c45820
Compare
nroggeman-ledger
force-pushed
the
fix-bagl-app-using-nbgl-lib
branch
from
4c45820 to
5ee6355
Compare
lpascal-ledger
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make BAGL-based applications able to call NBGL-based libraries, or NBGL-based applications able to call BAGL-based libraries.
It is especially important for Exchange (Swap) Application.
The main fix consist in supporting two instances of GraphicalLibrary (BAGL and NBGL), instead of a single one