This repository was archived by the owner on Jun 20, 2025. It is now read-only.
change IOFTV2 to IBaseOFTV2 and add a new implementation of IOFTV2 #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xb10ckdev
reviewed
Mar 19, 2025
Co-authored-by: 010x000 <[email protected]>
|
Hey sorry about the stale pr, can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the IOFTV2 interface naming misleading, as it seemed to be the interface for the OFTV2 contract. However, It is the interface for the BaseOFTV2 contract. I have renamed IOFTV2 -> IBaseOFTV2, and have created a new interface for the OFTV2 contract called IOFTV2.
Please let me know if any new tests need to be added or if there is a better way to go about this considering backwards compatibility.