Drop PHP 8.2 Support

README.md

@@ -11,7 +11,7 @@ The set provides best practices to make development more fun and classes/service
 | Requirement  | Constraint          | Supported by |
 |--------------|---------------------|------------------|
 |  PHP  | `^8.3` |   `HEAD ⋯ 5.0.0`   |
-|  | `^8.2` |   `HEAD ⋯ 2.0.0`   |
+|  | `^8.2` |   `7.1.0 ⋯ 2.0.0`   |
 |  | `^8.1` |   `6.4.2 ⋯ 2.0.0`   |
 |  | `^8.0` |   `4.6.0 ⋯ 2.0.0`   |
 |  | `^8.0.0` |   `1.1.2 ⋯ 0.12.0`   |

composer-dependency-analyser.php

@@ -14,7 +14,6 @@
 // General
 $config = (new Configuration())
     ->enableAnalysisOfUnusedDevDependencies()
-    ->ignoreErrorsOnPackage('symfony/polyfill-php83', [ErrorType::UNUSED_DEPENDENCY])
     ->ignoreErrorsOnPackage('bamarni/composer-bin-plugin', [ErrorType::UNUSED_DEPENDENCY])
     ->ignoreErrorsOnPackage('laravel/scout', [ErrorType::DEV_DEPENDENCY_IN_PROD])
     ->ignoreUnknownClasses([

composer-require-checker.json

@@ -49,6 +49,7 @@
     "Mockery\\Adapter\\Phpunit\\MockeryPHPUnitIntegration",
     "Orchestra\\Testbench\\TestCase",
     "PHPStan\\Analyser\\Scope",
+    "PHPStan\\Node\\ClassConstantsNode",
     "PHPStan\\Node\\InClassNode",
     "PHPStan\\Reflection\\ClassReflection",
     "PHPStan\\Reflection\\MethodReflection",

composer.json

@@ -32,7 +32,7 @@
     "forum": "https://github.com/LastDragon-ru/lara-asp/discussions"
   },
   "require": {
-    "php": "^8.2|^8.3",
+    "php": "^8.3",
     "ext-bcmath": "*",
     "ext-dom": "*",
     "ext-filter": "*",
@@ -65,7 +65,7 @@
     "league/commonmark": "^2.6.0",
     "league/config": "^1.1.1",
     "mockery/mockery": "^1.6.5",
-    "nette/neon": "^3.4",
+    "nette/neon": "^3.4.1",
     "nikic/php-parser": "^5.0",
     "nuwave/lighthouse": "^6.36.0",
     "opis/json-schema": "^2.3.0",
@@ -83,7 +83,6 @@
     "symfony/http-foundation": "^7.0.0",
     "symfony/http-kernel": "^7.0.0",
     "symfony/mime": "^7.0.0",
-    "symfony/polyfill-php83": "^1.28",
     "symfony/property-access": "^7.0.0",
     "symfony/property-info": "^7.0.0",
     "symfony/psr-http-message-bridge": "^7.0.0",

docs/Shared/Upgrade/FromV7.md

@@ -1 +1,2 @@
+* [ ] PHP 8.2 is not supported anymore. Migrate to the newer version.
 * [ ] Laravel v10 is not supported anymore. Migrate to the newer version.

metadata.json

@@ -8,8 +8,7 @@
                 "^11.0.8"
             ],
             "php": [
-                "^8.3",
-                "^8.2"
+                "^8.3"
             ]
         },
         "7.1.0": {

packages/core/README.md

@@ -11,7 +11,7 @@ This package contains useful utilities and classes.
 | Requirement  | Constraint          | Supported by |
 |--------------|---------------------|------------------|
 |  PHP  | `^8.3` |   `HEAD ⋯ 5.0.0`   |
-|  | `^8.2` |   `HEAD ⋯ 2.0.0`   |
+|  | `^8.2` |   `7.1.0 ⋯ 2.0.0`   |
 |  | `^8.1` |   `6.4.2 ⋯ 2.0.0`   |
 |  | `^8.0` |   `4.6.0 ⋯ 2.0.0`   |
 |  | `^8.0.0` |   `1.1.2 ⋯ 0.12.0`   |

packages/core/UPGRADE.md

@@ -33,6 +33,7 @@ Please also see [changelog](https://github.com/LastDragon-ru/lara-asp/releases)
 [//]: # (start: preprocess/c45228918cc92f69)
 [//]: # (warning: Generated automatically. Do not edit.)
 
+* [ ] PHP 8.2 is not supported anymore. Migrate to the newer version.
 * [ ] Laravel v10 is not supported anymore. Migrate to the newer version.
 
 [//]: # (end: preprocess/c45228918cc92f69)

packages/core/composer.json

@@ -18,14 +18,13 @@
     "forum": "https://github.com/LastDragon-ru/lara-asp/discussions"
   },
   "require": {
-    "php": "^8.2|^8.3",
+    "php": "^8.3",
     "illuminate/console": "^11.0.8",
     "illuminate/container": "^11.0.8",
     "illuminate/contracts": "^11.0.8",
     "illuminate/support": "^11.0.8",
     "symfony/deprecation-contracts": "^3.0.0",
-    "symfony/filesystem": "^7.0.0",
-    "symfony/polyfill-php83": "^1.28"
+    "symfony/filesystem": "^7.0.0"
   },
   "require-dev": {
     "phpunit/phpunit": "^10.5.0|^11.0.0",

packages/core/metadata.json

@@ -8,8 +8,7 @@
                 "^11.0.8"
             ],
             "php": [
-                "^8.3",
-                "^8.2"
+                "^8.3"
             ]
         },
         "7.1.0": {

packages/core/src/Package.php

@@ -3,5 +3,5 @@
 namespace LastDragon_ru\LaraASP\Core;
 
 final class Package {
-    public const Name = 'lara-asp-core';
+    public const string Name = 'lara-asp-core';
 }

packages/core/src/Utils/ConfigMerger.php

@@ -27,12 +27,12 @@ class ConfigMerger {
     /**
      * Array that has this mark may contains any keys/values.
      */
-    public const Strict = '__strict';
+    public const string Strict = '__strict';
 
     /**
      * Array that has this mark will be replaced completely.
      */
-    public const Replace = '__replace';
+    public const string Replace = '__replace';
 
     private bool $strict = true;
 

packages/core/src/Utils/Scheduler.php

@@ -15,6 +15,7 @@
 use function sprintf;
 
 /**
+ * @see https://github.com/mockery/mockery/issues/1317
  * @phpstan-type SchedulableSettings array{
  *      cron: string,
  *      enabled?: bool,

packages/dev/README.md

@@ -11,7 +11,7 @@ Various internal tools and helpers to develop the package itself.
 | Requirement  | Constraint          | Supported by |
 |--------------|---------------------|------------------|
 |  PHP  | `^8.3` |   `HEAD ⋯ 6.2.0`   |
-|  | `^8.2` |   `HEAD ⋯ 6.2.0`   |
+|  | `^8.2` |   `7.1.0 ⋯ 6.2.0`   |
 |  | `^8.1` |   `6.4.2 ⋯ 6.2.0`   |
 |  PHPStan  | `^1.10` |   `HEAD ⋯ 6.2.0`   |
 

packages/dev/UPGRADE.md

@@ -33,6 +33,7 @@ Please also see [changelog](https://github.com/LastDragon-ru/lara-asp/releases)
 [//]: # (start: preprocess/c45228918cc92f69)
 [//]: # (warning: Generated automatically. Do not edit.)
 
+* [ ] PHP 8.2 is not supported anymore. Migrate to the newer version.
 * [ ] Laravel v10 is not supported anymore. Migrate to the newer version.
 
 [//]: # (end: preprocess/c45228918cc92f69)

packages/dev/composer.json

@@ -18,14 +18,14 @@
     "forum": "https://github.com/LastDragon-ru/lara-asp/discussions"
   },
   "require": {
-    "php": "^8.2|^8.3",
+    "php": "^8.3",
     "illuminate/contracts": "^11.0.8",
     "illuminate/support": "^11.0.8",
     "larastan/larastan": "^2.8.1",
     "lastdragon-ru/lara-asp-core": "self.version",
     "lastdragon-ru/lara-asp-documentator": "self.version",
     "nikic/php-parser": "^5.0",
-    "nette/neon": "^3.4",
+    "nette/neon": "^3.4.1",
     "phpstan/phpstan": "^1.10",
     "symfony/var-dumper": "^7.0.0"
   },

packages/dev/metadata.json

@@ -8,8 +8,7 @@
     "requirements": {
         "HEAD": {
             "php": [
-                "^8.3",
-                "^8.2"
+                "^8.3"
             ],
             "phpstan/phpstan": [
                 "^1.10"

packages/dev/src/Package.php

@@ -3,5 +3,5 @@
 namespace LastDragon_ru\LaraASP\Dev;
 
 final class Package {
-    public const Name = 'lara-asp-dev';
+    public const string Name = 'lara-asp-dev';
 }

packages/dev/src/PhpStan/ClassConstantMustBeTyped/Rule.php

@@ -0,0 +1,73 @@
+<?php declare(strict_types = 1);
+
+namespace LastDragon_ru\LaraASP\Dev\PhpStan\ClassConstantMustBeTyped;
+
+use Illuminate\Support\Str;
+use LastDragon_ru\LaraASP\Dev\Package;
+use Override;
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Node\ClassConstantsNode;
+use PHPStan\Rules\Rule as RuleContract;
+use PHPStan\Rules\RuleErrorBuilder;
+
+use function reset;
+use function sprintf;
+
+/**
+ * Makes the `type` required for class constants (the type is required on level 10).
+ *
+ * @see https://github.com/slevomat/coding-standard/issues/1701
+ * @see https://github.com/slevomat/coding-standard/pull/1702
+ *
+ * @internal
+ * @implements RuleContract<ClassConstantsNode>
+ */
+readonly class Rule implements RuleContract {
+    public function __construct() {
+        // empty
+    }
+
+    #[Override]
+    public function getNodeType(): string {
+        return ClassConstantsNode::class;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    #[Override]
+    public function processNode(Node $node, Scope $scope): array {
+        // Typed?
+        $untyped = [];
+
+        foreach ($node->getConstants() as $constant) {
+            if ($constant->type === null) {
+                $untyped[] = $constant;
+            }
+        }
+
+        if ($untyped !== []) {
+            $id       = Str::camel(Package::Name).'.classConstantMustBeTyped';
+            $class    = $node->getClassReflection()->getName();
+            $message  = 'Class constant `%s::%s` must be typed.';
+            $messages = [];
+
+            foreach ($untyped as $constant) {
+                $const      = reset($constant->consts);
+                $name       = $const !== false ? $const->name : 'Unknown O_O';
+                $messages[] = RuleErrorBuilder::message(
+                    sprintf($message, $class, $name),
+                )
+                    ->line($constant->getLine())
+                    ->identifier($id)
+                    ->build();
+            }
+
+            return $messages;
+        }
+
+        // Nope
+        return [];
+    }
+}

packages/dev/src/PhpStan/ClassConstantMustBeTyped/RuleTest.php

@@ -0,0 +1,60 @@
+<?php declare(strict_types = 1);
+
+namespace LastDragon_ru\LaraASP\Dev\PhpStan\ClassConstantMustBeTyped;
+
+use Override;
+use PHPStan\Rules\Rule as RuleContract;
+use PHPStan\Testing\RuleTestCase;
+use PHPUnit\Framework\Attributes\CoversClass;
+
+use function sprintf;
+
+/**
+ * @internal
+ * @extends RuleTestCase<Rule>
+ */
+#[CoversClass(Rule::class)]
+final class RuleTest extends RuleTestCase {
+    #[Override]
+    protected function getRule(): RuleContract {
+        return new Rule();
+    }
+
+    public function testRule(): void {
+        $this->analyse([__FILE__], [
+            [
+                sprintf('Class constant `%s::%s` must be typed.', RuleTest_Constants::class, 'PublicUntyped'),
+                49,
+            ],
+            [
+                sprintf('Class constant `%s::%s` must be typed.', RuleTest_Constants::class, 'PrivateUntyped'),
+                50,
+            ],
+            [
+                sprintf('Class constant `%s::%s` must be typed.', RuleTest_Constants::class, 'ProtectedUntyped'),
+                51,
+            ],
+        ]);
+    }
+}
+
+// @phpcs:disable PSR1.Classes.ClassDeclaration.MultipleClasses
+// @phpcs:disable Squiz.Classes.ValidClassName.NotCamelCaps
+
+/**
+ * @internal
+ * @noinspection PhpMultipleClassesDeclarationsInOneFile
+ */
+class RuleTest_Constants {
+    public const        PublicUntyped    = 123;
+    private const       PrivateUntyped   = 123;
+    protected const     ProtectedUntyped = 123;
+    public const int    PublicTyped      = 123;
+    private const int   PrivateTyped     = 123;
+    protected const int ProtectedTyped   = 123;
+
+    public function __construct() {
+        echo self::PrivateTyped;
+        echo self::PrivateUntyped;
+    }
+}

packages/dev/src/PhpStan/ClassConstantMustBeTyped/extension.neon

@@ -0,0 +1,5 @@
+services:
+    -
+        class: LastDragon_ru\LaraASP\Dev\PhpStan\ClassConstantMustBeTyped\Rule
+        tags:
+            - phpstan.rules.rule

packages/dev/src/PhpStan/ClassMustBeFinal/Rule.php

@@ -20,12 +20,12 @@
  * @internal
  * @implements RuleContract<InClassNode>
  */
-class Rule implements RuleContract {
+readonly class Rule implements RuleContract {
     public function __construct(
         /**
          * @var array<array-key, class-string>
          */
-        protected readonly array $classes,
+        protected array $classes,
     ) {
         // empty
     }

packages/dev/src/PhpStan/ClassMustBeInternal/Rule.php

@@ -27,16 +27,16 @@
  * @internal
  * @implements RuleContract<InClassNode>
  */
-class Rule implements RuleContract {
+readonly class Rule implements RuleContract {
     public function __construct(
         /**
          * @var array<array-key, class-string>
          */
-        protected readonly array $classes,
+        protected array $classes,
         /**
          * @var array<array-key, class-string>
          */
-        protected readonly array $ignored = [],
+        protected array $ignored = [],
     ) {
         // empty
     }

packages/documentator/README.md

@@ -11,7 +11,7 @@ This package provides various utilities for documentation generation such as Mar
 | Requirement  | Constraint          | Supported by |
 |--------------|---------------------|------------------|
 |  PHP  | `^8.3` |   `HEAD ⋯ 5.0.0`   |
-|  | `^8.2` |   `HEAD ⋯ 5.0.0-beta.1`   |
+|  | `^8.2` |   `7.1.0 ⋯ 5.0.0-beta.1`   |
 |  | `^8.1` |   `6.4.2 ⋯ 5.0.0-beta.1`   |
 |  Laravel  | `^11.0.8` |  `HEAD`   |
 |  | `^11.0.0` |   `7.1.0 ⋯ 6.2.0`   |

packages/documentator/UPGRADE.md

@@ -33,6 +33,7 @@ Please also see [changelog](https://github.com/LastDragon-ru/lara-asp/releases)
 [//]: # (start: preprocess/c45228918cc92f69)
 [//]: # (warning: Generated automatically. Do not edit.)
 
+* [ ] PHP 8.2 is not supported anymore. Migrate to the newer version.
 * [ ] Laravel v10 is not supported anymore. Migrate to the newer version.
 
 [//]: # (end: preprocess/c45228918cc92f69)

packages/documentator/composer.json

@@ -18,7 +18,7 @@
     "forum": "https://github.com/LastDragon-ru/lara-asp/discussions"
   },
   "require": {
-    "php": "^8.2|^8.3",
+    "php": "^8.3",
     "ext-filter": "*",
     "ext-intl": "*",
     "ext-mbstring": "*",
@@ -35,7 +35,6 @@
     "symfony/deprecation-contracts": "^3.0.0",
     "symfony/filesystem": "^7.0.0",
     "symfony/finder": "^7.0.0",
-    "symfony/polyfill-php83": "^1.28",
     "symfony/serializer": "^7.0.0",
     "lastdragon-ru/lara-asp-core": "self.version",
     "lastdragon-ru/lara-asp-formatter": "self.version",