chore: Deprecated class/methods marked by trigger_deprecation() (#148)

LastDragon-ru · Mar 25, 2024 · 4979a4e · 4979a4e
2 parents b09890e + c2a08ea
commit 4979a4e
Show file tree

Hide file tree

Showing 27 changed files with 89 additions and 10 deletions.
diff --git a/packages/core/composer.json b/packages/core/composer.json
@@ -22,6 +22,7 @@
     "illuminate/console": "^10.34.0",
     "illuminate/container": "^10.34.0",
     "illuminate/contracts": "^10.34.0",
+    "symfony/deprecation-contracts": "^3.0.0",
     "symfony/filesystem": "^6.3.0",
     "symfony/polyfill-php83": "^1.28"
   },

diff --git a/packages/core/phpunit.xml b/packages/core/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/core/src/Observer/Dispatcher.php b/packages/core/src/Observer/Dispatcher.php
@@ -3,6 +3,7 @@
 namespace LastDragon_ru\LaraASP\Core\Observer;
 
 use Closure;
+use LastDragon_ru\LaraASP\Core\Package;
 use Override;
 use SplObjectStorage;
 use function array_values;
@@ -60,6 +61,8 @@ public function notify(mixed $context = null): static {
      * @return list<Closure(TContext):void>
      */
     public function getObservers(): array {
+        trigger_deprecation(Package::Name, '5.1.0', 'The method should not be used.');
+
         return array_values(iterator_to_array($this->observers));
     }
 }
diff --git a/packages/documentator/composer.json b/packages/documentator/composer.json
@@ -30,6 +30,7 @@
     "nikic/php-parser": "^4.18|^5.0",
     "phpstan/phpdoc-parser": "^1.25",
     "symfony/console": "^6.3.0",
+    "symfony/deprecation-contracts": "^3.0.0",
     "symfony/filesystem": "^6.3.0",
     "symfony/finder": "^6.3.0",
     "symfony/polyfill-php83": "^1.28",

diff --git a/packages/documentator/phpunit.xml b/packages/documentator/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/documentator/src/Utils/Path.php b/packages/documentator/src/Utils/Path.php
@@ -3,6 +3,13 @@
 namespace LastDragon_ru\LaraASP\Documentator\Utils;
 
 use LastDragon_ru\LaraASP\Core\Utils\Path as CorePath;
+use LastDragon_ru\LaraASP\Documentator\Package;
+
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '%{VERSION}', 'Please use `%s` instead.', CorePath::class);
 
 /**
  * @deprecated %{VERSION} Use {@see CorePath} instead.

diff --git a/packages/eloquent/phpunit.xml b/packages/eloquent/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/formatter/phpunit.xml b/packages/formatter/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/graphql/composer.json b/packages/graphql/composer.json
@@ -32,6 +32,7 @@
     "lastdragon-ru/lara-asp-eloquent": "self.version",
     "lastdragon-ru/lara-asp-graphql-printer": "self.version",
     "lastdragon-ru/lara-asp-serializer": "self.version",
+    "symfony/deprecation-contracts": "^3.0.0",
     "symfony/polyfill-php83": "^1.28",
     "webonyx/graphql-php": "^15.4.0"
   },

diff --git a/packages/graphql/phpunit.xml b/packages/graphql/phpunit.xml
@@ -31,6 +31,5 @@
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
         <env verbatim="true" name="SCOUT_DRIVER" value="null"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/graphql/src/Builder/Contracts/Scout/FieldResolver.php b/packages/graphql/src/Builder/Contracts/Scout/FieldResolver.php
@@ -5,6 +5,13 @@
 use Illuminate\Database\Eloquent\Model;
 use LastDragon_ru\LaraASP\GraphQL\Builder\Contracts\BuilderFieldResolver;
 use LastDragon_ru\LaraASP\GraphQL\Builder\Property;
+use LastDragon_ru\LaraASP\GraphQL\Package;
+
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.4.0', 'Please use `%s` instead.', BuilderFieldResolver::class);
 
 /**
  * Convert nested property into Scout field.

diff --git a/packages/graphql/src/Builder/Directives/OperatorsDirective.php b/packages/graphql/src/Builder/Directives/OperatorsDirective.php
@@ -2,13 +2,19 @@
 
 namespace LastDragon_ru\LaraASP\GraphQL\Builder\Directives;
 
+use LastDragon_ru\LaraASP\GraphQL\Package;
 use Nuwave\Lighthouse\Schema\DirectiveLocator;
 use Override;
 
 use function array_unique;
 use function assert;
 use function implode;
 use function is_string;
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.6.0', 'Please use `%s` instead.', ExtendOperatorsDirective::class);
 
 /**
  * @deprecated 5.6.0 Use {@see ExtendOperatorsDirective} instead.

diff --git a/packages/graphql/src/Builder/Property.php b/packages/graphql/src/Builder/Property.php
@@ -2,6 +2,14 @@
 
 namespace LastDragon_ru\LaraASP\GraphQL\Builder;
 
+use LastDragon_ru\LaraASP\GraphQL\Package;
+
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.5.0', 'Please use `%s` instead.', Field::class);
+
 /**
  * @deprecated 5.5.0 Please use {@see Field} instead.
  */

diff --git a/packages/graphql/src/SearchBy/Definitions/SearchByOperatorRelationDirective.php b/packages/graphql/src/SearchBy/Definitions/SearchByOperatorRelationDirective.php
@@ -2,8 +2,15 @@
 
 namespace LastDragon_ru\LaraASP\GraphQL\SearchBy\Definitions;
 
+use LastDragon_ru\LaraASP\GraphQL\Package;
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Operators\Complex\Relationship;
 
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.6.0', 'Please use `%s` instead.', SearchByOperatorRelationshipDirective::class);
+
 /**
  * @deprecated 5.6.0 Please use {@see SearchByOperatorRelationshipDirective}.
  */

diff --git a/packages/graphql/src/SearchBy/Definitions/SearchByOperatorsDirective.php b/packages/graphql/src/SearchBy/Definitions/SearchByOperatorsDirective.php
@@ -2,8 +2,15 @@
 
 namespace LastDragon_ru\LaraASP\GraphQL\SearchBy\Definitions;
 
+use LastDragon_ru\LaraASP\GraphQL\Package;
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Directives\Operators;
 
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.6.0', 'Please use `%s` instead.', SearchByExtendOperatorsDirective::class);
+
 /**
  * @deprecated 5.6.0 Use {@see SearchByExtendOperatorsDirective} instead.
  */

diff --git a/packages/graphql/src/SearchBy/Directives/Operators.php b/packages/graphql/src/SearchBy/Directives/Operators.php
@@ -3,8 +3,15 @@
 namespace LastDragon_ru\LaraASP\GraphQL\SearchBy\Directives;
 
 use LastDragon_ru\LaraASP\GraphQL\Builder\Directives\OperatorsDirective;
+use LastDragon_ru\LaraASP\GraphQL\Package;
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Contracts\Scope;
 
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.6.0', 'Please use `%s` instead.', ExtendOperators::class);
+
 /**
  * @deprecated 5.6.0 Use {@see ExtendOperators} instead.
  */

diff --git a/packages/graphql/src/SearchBy/Types/Condition/V5.php b/packages/graphql/src/SearchBy/Types/Condition/V5.php
@@ -5,9 +5,16 @@
 use LastDragon_ru\LaraASP\GraphQL\Builder\Context\HandlerContextBuilderInfo;
 use LastDragon_ru\LaraASP\GraphQL\Builder\Contracts\Context;
 use LastDragon_ru\LaraASP\GraphQL\Builder\Contracts\TypeSource;
+use LastDragon_ru\LaraASP\GraphQL\Package;
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Directives\Directive;
 use Override;
 
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.5.0', 'Please migrate to the new query structure.');
+
 /**
  * @deprecated 5.5.0 Please migrate to the new query structure.
  */

diff --git a/packages/graphql/src/SortBy/Types/Clause/V5.php b/packages/graphql/src/SortBy/Types/Clause/V5.php
@@ -5,9 +5,16 @@
 use LastDragon_ru\LaraASP\GraphQL\Builder\Context\HandlerContextBuilderInfo;
 use LastDragon_ru\LaraASP\GraphQL\Builder\Contracts\Context;
 use LastDragon_ru\LaraASP\GraphQL\Builder\Contracts\TypeSource;
+use LastDragon_ru\LaraASP\GraphQL\Package;
 use LastDragon_ru\LaraASP\GraphQL\SortBy\Directives\Directive;
 use Override;
 
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '5.5.0', 'Please migrate to the new query structure.');
+
 /**
  * @deprecated 5.5.0 Please migrate to the new query structure.
  */

diff --git a/packages/migrator/phpunit.xml b/packages/migrator/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/serializer/phpunit.xml b/packages/serializer/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/spa/composer.json b/packages/spa/composer.json
@@ -31,6 +31,7 @@
     "illuminate/validation": "^10.34.0",
     "guzzlehttp/psr7": "^1.9.1|^2.4.5",
     "lastdragon-ru/lara-asp-core": "self.version",
+    "symfony/deprecation-contracts": "^3.0.0",
     "symfony/http-kernel": "^6.3.0",
     "symfony/polyfill-php83": "^1.28"
   },

diff --git a/packages/spa/phpunit.xml b/packages/spa/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/spa/src/Http/Request.php b/packages/spa/src/Http/Request.php
@@ -3,8 +3,15 @@
 namespace LastDragon_ru\LaraASP\Spa\Http;
 
 use Illuminate\Foundation\Http\FormRequest;
+use LastDragon_ru\LaraASP\Spa\Package;
 use Override;
 
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '%{VERSION}', 'Please use own class and `%s` trait.', WithValueProvider::class);
+
 /**
  * @deprecated %{VERSION} Please use own class and {@see WithValueProvider} trait.
  */

diff --git a/packages/testing/phpunit.xml b/packages/testing/phpunit.xml
@@ -27,6 +27,5 @@
         <env verbatim="true" name="APP_DEBUG" value="true"/>
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>
diff --git a/packages/testing/src/Assertions/ResponseAssertions.php b/packages/testing/src/Assertions/ResponseAssertions.php
@@ -3,10 +3,13 @@
 namespace LastDragon_ru\LaraASP\Testing\Assertions;
 
 use LastDragon_ru\LaraASP\Testing\Constraints\Response\Response;
+use LastDragon_ru\LaraASP\Testing\Package;
 use PHPUnit\Framework\Assert;
 use PHPUnit\Framework\Constraint\Constraint;
 use Psr\Http\Message\ResponseInterface;
 
+use function trigger_deprecation;
+
 /**
  * @mixin Assert
  */
@@ -21,6 +24,8 @@ public static function assertThatResponse(
         Constraint $constraint,
         string $message = '',
     ): void {
+        trigger_deprecation(Package::Name, '6.0.0', 'Please use `static::assertPsrResponse()` instead.');
+
         static::assertThat($response, $constraint, $message);
     }
 

diff --git a/packages/testing/src/Database/RefreshDatabaseIfEmpty.php b/packages/testing/src/Database/RefreshDatabaseIfEmpty.php
@@ -6,8 +6,15 @@
 use Illuminate\Database\DatabaseManager;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Foundation\Testing\RefreshDatabaseState;
+use LastDragon_ru\LaraASP\Testing\Package;
 use PHPUnit\Framework\TestCase;
 
+use function trigger_deprecation;
+
+// phpcs:disable PSR1.Files.SideEffects
+
+trigger_deprecation(Package::Name, '%{VERSION}', 'Please use own trait.');
+
 /**
  * The trait is very similar to standard {@link RefreshDatabase} but there is one
  * difference: it will refresh the database only if it is empty. This is very

diff --git a/phpunit.xml b/phpunit.xml
@@ -109,6 +109,5 @@
         <env verbatim="true" name="DB_CONNECTION" value="sqlite"/>
         <env verbatim="true" name="DB_DATABASE" value=":memory:"/>
         <env verbatim="true" name="SCOUT_DRIVER" value="null"/>
-        <env verbatim="true" name="TESTBENCH_CONVERT_DEPRECATIONS_TO_EXCEPTIONS" value="true"/>
     </php>
 </phpunit>