Repository navigation
fix(graph): macOS delete key removes nodes; Timer settings off the canvas - #186
Merged
Merged
Conversation
… off the canvas Backspace (labelled "delete" on Mac keyboards) now removes the selected nodes and connections, unless an embedded node widget has focus. Timer no longer draws Interval/Enabled input ports; its interval and unit live in the properties panel, as Delay's duration does. Fixes #51, fixes #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51, fixes #52.
Key_Backspace, which is the key Mac keyboards label "delete". It is skipped while an embedded node widget has focus, so typing in one still works.Interval/Enabledinput ports on the node. Interval and unit live in the properties panel, the same way Delay's duration does. Runtime is unchanged.Tests: new
tests/unit/gui/test_graph_delete_key.py(Delete and Backspace); the Timer port test now expects no inputs.Full gate: 5791 passed, 4 skipped, 5 deselected; ruff and black clean.