Skip to content

Conversation

@gamerboysgamingwelt
Copy link

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.flipsyy.de seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name! (all lowercase)

  • Please use your own page, not LABY.net (user_stats)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@github-actions
Copy link

Just as an information:

  • It seems you're using the template regex for chat message! Please make sure it is the right regex for your server!

"nice_name": "Flipsyy",
"direct_ip": "flipsyy.de",
"server_wildcards": [
"%.flipsyy.de"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"color": "#FFA500",
"versions": "1.9<*"
},
"PVP-Arena": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON naming conventions
Change to lowercase/camelCase

"youtube": "https://www.youtube.com/@fiipsy"
},
"gamemodes": {
"SMP": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON naming conventions
Change to lowercase/camelCase

},
"chat": {
"message_formats": [
"^§[a-f0-9](?<level>\\d+)( \\||§8 \\|) §[a-f0-9](?<sender>[a-zA-Z0-9_]{2,16})§r§7: §f(?<message>.*)$"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's our template regex
Either add your own or remove completely

"country": "Germany",
"country_code": "DE"
},
"user_stats": "https://laby.net/@{uuid}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's our own, either add our own or remove completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants