Skip to content

Annotate overrides #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 1 commit into from
Sep 21, 2026
Merged

Annotate overrides #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CageUI/src/org/labkey/cageui/query/AllHistoryTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public UpdateService(SimpleUserSchema.SimpleTable ti)

// This checks permission before any data modification occurs
@Override
public boolean hasPermission(@NotNull UserPrincipal user, Class<? extends Permission> perm)
public boolean hasPermission(@NotNull UserPrincipal user, @NotNull Class<? extends Permission> perm)
{
boolean hasPermission = super.hasPermission(user, perm);
boolean isEditPerm = perm == InsertPermission.class || perm == UpdatePermission.class || perm == DeletePermission.class;
Expand Down
2 changes: 1 addition & 1 deletion CageUI/src/org/labkey/cageui/query/CageHistoryTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public UpdateService(SimpleUserSchema.SimpleTable ti)

// This checks permission before any data modification occurs
@Override
public boolean hasPermission(@NotNull UserPrincipal user, Class<? extends Permission> perm)
public boolean hasPermission(@NotNull UserPrincipal user, @NotNull Class<? extends Permission> perm)
{
boolean hasPermission = super.hasPermission(user, perm);
boolean isEditPerm = perm == InsertPermission.class || perm == UpdatePermission.class || perm == DeletePermission.class;
Expand Down
2 changes: 1 addition & 1 deletion CageUI/src/org/labkey/cageui/query/CageModificationsHistoryTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public UpdateService(SimpleUserSchema.SimpleTable ti)

// This checks permission before any data modification occurs
@Override
public boolean hasPermission(@NotNull UserPrincipal user, Class<? extends Permission> perm)
public boolean hasPermission(@NotNull UserPrincipal user, @NotNull Class<? extends Permission> perm)
{
boolean hasPermission = super.hasPermission(user, perm);
boolean isEditPerm = perm == InsertPermission.class || perm == UpdatePermission.class || perm == DeletePermission.class;
Expand Down
2 changes: 1 addition & 1 deletion CageUI/src/org/labkey/cageui/query/CageModificationsTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public UpdateService(SimpleUserSchema.SimpleTable ti)

// This checks permission before any data modification occurs
@Override
public boolean hasPermission(@NotNull UserPrincipal user, Class<? extends Permission> perm)
public boolean hasPermission(@NotNull UserPrincipal user, @NotNull Class<? extends Permission> perm)
{
boolean hasPermission = super.hasPermission(user, perm);
boolean isEditPerm = perm == InsertPermission.class || perm == UpdatePermission.class || perm == DeletePermission.class;
Expand Down
3 changes: 1 addition & 2 deletions CageUI/src/org/labkey/cageui/query/CagesTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
import org.labkey.cageui.security.permissions.CageUIAnimalEditorPermission;
import org.labkey.cageui.security.permissions.CageUILayoutEditorAccessPermission;
import org.labkey.cageui.security.permissions.CageUIModificationEditorPermission;
import org.labkey.cageui.security.permissions.CageUIRoomCreatorPermission;

import java.sql.SQLException;
import java.util.List;
Expand Down Expand Up @@ -67,7 +66,7 @@ public UpdateService(SimpleUserSchema.SimpleTable ti)

// This checks permission before any data modification occurs
@Override
public boolean hasPermission(@NotNull UserPrincipal user, Class<? extends Permission> perm)
public boolean hasPermission(@NotNull UserPrincipal user, @NotNull Class<? extends Permission> perm)
{
boolean hasPermission = super.hasPermission(user, perm);
boolean isEditPerm = perm == InsertPermission.class || perm == UpdatePermission.class || perm == DeletePermission.class;
Expand Down
2 changes: 1 addition & 1 deletion CageUI/src/org/labkey/cageui/query/RoomHistoryTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public UpdateService(SimpleUserSchema.SimpleTable ti)

// This checks permission before any data modification occurs
@Override
public boolean hasPermission(@NotNull UserPrincipal user, Class<? extends Permission> perm)
public boolean hasPermission(@NotNull UserPrincipal user, @NotNull Class<? extends Permission> perm)
{
boolean hasPermission = super.hasPermission(user, perm);
boolean isEditPerm = perm == InsertPermission.class || perm == UpdatePermission.class || perm == DeletePermission.class;
Expand Down
4 changes: 1 addition & 3 deletions CageUI/src/org/labkey/cageui/query/TemplateLayoutHistoryTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@
import org.labkey.api.security.permissions.InsertPermission;
import org.labkey.api.security.permissions.Permission;
import org.labkey.api.security.permissions.UpdatePermission;
import org.labkey.cageui.security.permissions.CageUILayoutEditorAccessPermission;
import org.labkey.cageui.security.permissions.CageUIRoomCreatorPermission;
import org.labkey.cageui.security.permissions.CageUITemplateCreatorPermission;

import java.sql.SQLException;
Expand Down Expand Up @@ -66,7 +64,7 @@ public UpdateService(SimpleUserSchema.SimpleTable ti)

// This checks permission before any data modification occurs
@Override
public boolean hasPermission(@NotNull UserPrincipal user, Class<? extends Permission> perm)
public boolean hasPermission(@NotNull UserPrincipal user, @NotNull Class<? extends Permission> perm)
{
boolean hasPermission = super.hasPermission(user, perm);
boolean isEditPerm = perm == InsertPermission.class || perm == UpdatePermission.class || perm == DeletePermission.class;
Expand Down
Loading