Refactor MailHelper to be more provider-agnostic#3108
Open
labkey-adam wants to merge 2 commits into
Open
Conversation
|
|
||
| // Install our own SMTP provider pointed at the local capture server and make it the active provider, rather | ||
| // than mutating another provider's session state. All outgoing email is captured regardless of how the server's | ||
| // real email transport (SMTP, Microsoft Graph, etc.) is configured. |
Contributor
There was a problem hiding this comment.
I could be misreading this - but I read these two sentences like a contradiction on first pass: sentence 1 says we install our own SMTP provider, sentence 2 says we capture email regardless of transport including Graph (implies Dumbster handles Graph traffic, but of course we're just replacing the active provider).
Contributor
Author
There was a problem hiding this comment.
AI-generated comment that could be clearer. I'll clean it up.
labkey-bpatel
approved these changes
Jul 21, 2026
labkey-bpatel
left a comment
labkey-bpatel
left a comment
Contributor
There was a problem hiding this comment.
Please see my comment regarding a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Dumbster changes to support a somewhat more agnostic MailHelper
Related Pull Requests