Issue 53394: FileInput revert removal of the "-fileUpload" suffix from inputId #2532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested changes
Jul 3, 2025
src/org/labkey/test/components/ui/files/FileAttachmentContainer.java
Outdated
Show resolved
Hide resolved
Comment on lines
273
to
276
| public FileUploadField getExistingFileField(String fieldIdentifier) | ||
| { | ||
| return enableAndWait(fieldIdentifier, elementCache().fileField(fieldIdentifier)); | ||
| String identifier = FileAttachmentContainer.fileUploadIdentifier(fieldIdentifier.toString()); | ||
| return enableAndWait(identifier, elementCache().fileField(identifier)); |
There was a problem hiding this comment.
This should take a CharSequence, not a String.
Also, what is the distinction between getFileField and getExistingFileField? (Maybe more of a question for Xing since she added the latter)
There was a problem hiding this comment.
I believe that the getExistingFileField is to get the file card for an existing file and the getFileField is to get the file upload input when no file exists for the field. I'm renaming getExistingFileField to getExistingFileCard, maybe that will help a bit.
labkey-tchad
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 53394: LKSM: Selection of file doesn't work on develop
Revert changes from LabKey/labkey-ui-components#1800
Related Pull Requests
Changes