Skip to content

Add test automation for miscellaneous sample and sample type issues. #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c502fc4
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 12, 2025
fcc60fa
Add a test to cover sample type name containing a period and used as …
labkey-danield Jun 13, 2025
5a3a3b8
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 17, 2025
7c271bb
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 18, 2025
7bb118b
Add a test that checks tricky characters in field names that are also…
labkey-danield Jun 18, 2025
2b6a19b
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 19, 2025
f24c267
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 20, 2025
848afe7
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 23, 2025
6f96cdc
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 25, 2025
8e45228
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 26, 2025
09af95d
Merge develop into fb_miscSampleTypeNeedsAutomation.
labkey-danield Jun 27, 2025
6b83279
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 27, 2025
89b9161
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jun 30, 2025
d907ea7
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jul 1, 2025
0da2668
Avoid issue 53315 by having variations in the field names.
labkey-danield Jul 1, 2025
796e524
Update the expected value from the field on the parent sample.
labkey-danield Jul 1, 2025
a2c63d7
Merge branch 'develop' into fb_miscSampleTypeNeedsAutomation
labkey-danield Jul 2, 2025
e33da79
remove replaceAll
labkey-danield Jul 2, 2025
c5dd517
Implementing code review feedback.
labkey-danield Jul 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -366,13 +366,26 @@ public List<String> getParentAliasOptions(int index)
}

public T setParentAlias(int index, @Nullable String alias, @Nullable String optionDisplayText)
{
return setParentAlias(index, alias, optionDisplayText, false);
}

public T setParentAlias(int index, @Nullable String alias, @Nullable String optionDisplayText, boolean isRequired)
{
expandPropertiesPanel();
elementCache().parentAlias(index).setValue(alias);
if (optionDisplayText != null)
{
elementCache().parentAliasSelect(index).select(optionDisplayText);
}

// The "Required" checkbox is not presented outside of the apps. Only a test running in the app could set
// this parent field to being required.
if (isRequired)
{
getWrapper().setCheckbox(elementCache().parentAliasRequiredCheckbox(index), isRequired);
}

return getThis();
}

Expand Down Expand Up @@ -447,6 +460,12 @@ public Input parentAlias(int index)
return parentAliases().get(index);
}

public WebElement parentAliasRequiredCheckbox(int index)
{
return Locator.tagWithName("input","required").withAttribute("type", "checkbox")
.findElements(propertiesPanel).get(index);
}

public WebElement removeParentAliasIcon(int index)
{
return Locator.tagWithClass("span","domain-field-delete-icon").findElements(propertiesPanel).get(index);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ public T addParentAlias(String alias)
}

public T addParentAlias(String alias, @Nullable String optionDisplayText)
{
return addParentAlias(alias, optionDisplayText, false);
}

public T addParentAlias(String alias, @Nullable String optionDisplayText, boolean isRequired)
{
expandPropertiesPanel();

Expand All @@ -54,7 +59,7 @@ public T addParentAlias(String alias, @Nullable String optionDisplayText)
{
optionDisplayText = CURRENT_SAMPLE_TYPE;
}
setParentAlias(initialCount, alias, optionDisplayText);
setParentAlias(initialCount, alias, optionDisplayText, isRequired);
return getThis();
}

Expand Down
Loading