Fix data region column name references #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary logging parameters from CustomizeViewHelper Update CustomizeViewHelper to use FieldKey
|
ERROR: A pull request from |
| @@ -397,7 +397,6 @@ protected void verifyMolecule() | |||
|
|
|||
| //Look for Small Molecule Precursor List data region | |||
| drt = DataRegion(getDriver()).withName("small_mol_precursors_view").index(1).find(); | |||
| assertEquals("PC aa C30:1", drt.getDataAsText(5, "Custom Ion Name")); | |||
There was a problem hiding this comment.
???
Can you add a note in the comment/conversation part of this PR why this check is being removed?
There was a problem hiding this comment.
I updated the description to include my reasoning. (tldr; this assertion is redundant)
labkey-danield
approved these changes
Jul 2, 2025
labkey-chrisj
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
My previous DataRegionTable refactor attempted to recreate the previous behavior that would remove spaces when matching field labels. I covered the case where the test passed in an unnecessary space but not when they omitted a space. Rather that duplicating that particular behavior, this updates the handful of tests that are passing incorrect field labels.
For this test in particular, "CustomIonName" and "Precursor" are the same column. I removed one since they are redundant. I picked the label ("Precursor") to be consistent with the rest of the assertions here.
Related Pull Requests
Changes