Skip to content

Update location queries - #1029

Merged
labkey-bpatel merged 1 commit into
release26.3-SNAPSHOTfrom
26.3_fb_snprc_isnumeric_condition
Oct 29, 2026
Merged

labkey-bpatel merged 1 commit into
release26.3-SNAPSHOTfrom
26.3_fb_snprc_isnumeric_condition

Conversation

@labkey-bpatel

@labkey-bpatel labkey-bpatel commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Rationale

These changes are already in the SNPRC migration feature branch, but that branch isn't merged yet, so this brings them in now so SNPRC_EHRTest passes on SQL Server.

Related Pull Requests

Changes

  • Compare isnumeric() to 1 in the location queries

isnumeric() now returns 1/0, which SQL Server rejects as a bare CASE condition.

@labkey-bpatel labkey-bpatel left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL Server tests are passing now.

@labkey-bpatel
labkey-bpatel merged commit a32c9a8 into release26.3-SNAPSHOT Oct 29, 2026
9 of 10 checks passed
@labkey-bpatel
labkey-bpatel deleted the 26.3_fb_snprc_isnumeric_condition branch October 29, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants