[bot] Fast-forward for 26.7.8 - #8032
Merged
Merged
Conversation
## Rationale Joins can be more efficient in Postgres compared to doing a subquery multiple times. This supports pulling inventory data into a sample's grid much more efficiently. ## Related Pull Requests - LabKey/limsModules#2449 ## Changes - Expose a method for injecting the join
## Rationale Calls to `analyze()` on a GET request were always failing. Noticed locally while testing flow attributes.
…8015) ## Rationale `onDragEnd` compared `globalSettings` against the whole `dirtinessData` object instead of `dirtinessData.globalSettings`, and `isEquivalent` compares key counts first, so `dirty` was unconditionally true after any drag-end — the unsaved-changes banner and navigate-away warning appeared even when a row was dropped back in place. `AuthenticationProviderReorderTest` relied on that banner to confirm the drag had landed, so it could not tell a failed drop from a successful one. ## Related Pull Requests - LabKey/testAutomation#3183 ## Changes - `AuthenticationConfiguration.onDragEnd` compares against `dirtinessData.globalSettings`, matching how `globalAuthOnChange` already does it. - `AuthenticationProviderReorderTest` reorders through `keyboardDragAndDrop` and waits for the now-meaningful unsaved-changes banner before saving. <!-- list of standard tasks (remove this comment to enable) ## Tasks - [ ] Claude Code Review - [ ] Manual Testing - [ ] Test Automation - [ ] Verify Fix -->
… exceptions on specimen tables (#8011)
…7929) - Add a REAUTHENTICATED user audit event - Split the single "wrong user reauthenticated" error into three, - Log a warning when reauthentication fails in a way an administrator can act on
…ups (#8020) ## Rationale Speed up sample and list operations by taking per-row work out of the audit write path, the list audit formatter, and import lookup resolution. Create custom sample type indices in the materialized tables so that grids over large sample types stop scanning. ## Related Pull Requests - #8020 - LabKey/limsModules#2461 ## Changes - Collect audit events raised while building another audit record and write them in batches rather than one insert each - Cache each audit type's provisioned storage table instead of rebuilding a schema and table for every event inserted - Resolve the list audit formatter once per operation instead of once per row, and batch the row events it produces - Stop discarding import lookup memoization mid import so a repeated value resolves once - Mirror a sample type's admin defined indices onto its materialized table, and add a name index - Build the materialized table's non essential indices after it is published to readers so queries are not held behind the slowest index - Scope cached transaction audit events by container and audit log permission so they match what a database read returns - Add integration tests for the list audit batch boundary, the mirrored domain index, lookup memoization, and cached transaction event scoping ## Tasks - [ ] Claude Code Review - [ ] Manual Testing - [x] Test Automation
## Rationale There's an intermittent test failure when a sample type's name overlaps with the RowId of another sample type, exposed by the optimizations in #8020. ## Changes - Revert optimization, to be restored in another PR
DariaBod
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.7_ff_bot_26.7.8