Use standard DDL instead of fn_dropifexists() proc - #8021
Merged
Merged
Conversation
labkey-klum
approved these changes
Sep 4, 2026
labkey-adam
added a commit
that referenced
this pull request
Sep 11, 2026
## Rationale Standard PostgreSQL statements support `DROP IF EXISTS` variants for all objects that we care about. We've deprecated our custom `core.fn_dropifexists` stored function since it's no longer needed. For now, remove the ability to drop AGGREGATE, DEFAULT, FUNCTION, PROCEDURE, and SCHEMA, since these are rarely used. We're leaving the function in place (supporting only five more common object types) for now to ease merges forward from older branches that might use it. LabKey/internal-issues#1502 ## Related Pull Requests - #8021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Our custom stored procedure
fb_dropifexists()is no longer useful