Collect CachedResultSet creation stack traces#7394
Merged
labkey-adam merged 2 commits intodevelopfrom Feb 7, 2026
Merged
Conversation
labkey-jeckels
approved these changes
Feb 6, 2026
Contributor
Author
|
FYI: @DariaBod @labkey-tchad @labkey-danield after merge to develop, any "CachedResultSet was not closed" error should now come with a stack trace, as long as the server is running in dev mode. The stack trace should help point you to a dev owner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We want to track down code paths that aren't closing CachedResultSets; that's nearly impossible without stack traces. This change collects CachedResultSet creation stack traces in dev mode. We'll likely revert this after we've fixed the issue(s) showing up on TeamCity.